[de-xbl] convert toolbar.xml#menu-button binding to custom element
Categories
(Thunderbird :: Toolbars and Tabs, task)
Tracking
(Not tracked)
People
(Reporter: mkmelin, Assigned: mkmelin)
References
Details
Attachments
(1 file, 3 obsolete files)
(deleted),
patch
|
aleca
:
review+
khushil324
:
review+
|
Details | Diff | Splinter Review |
Not to be confused with bug 1546352 (which is very related, but not the same)
Convert the toolbar.xml#menu-button binding to custom element.
https://searchfox.org/comm-central/rev/01f50ef57ff126a8a8146f9091a44d3ff0b31d4e/common/bindings/toolbar.xml#519
This binding inherits button-base which will be removed in bug 1519577.
Assignee | ||
Comment 1•5 years ago
|
||
This seems to do it (with arc patch D31941 ).
One thing is missing in action: new Write button now longer has the lightning items. Lightning overlays this (button-newmsg) but button-newmsg is not a menu-button toolbarbutton to start with (in thunderbird core), "is" can't be set dynamically, and it can't be a toolbarbutton-menu-button initially when there is no child element... I experimented a bunch with changing the internals dynamically, but couldn't make that work properly.
Assignee | ||
Comment 2•5 years ago
|
||
Comment 3•5 years ago
|
||
Comment 4•5 years ago
|
||
Assignee | ||
Comment 5•5 years ago
|
||
I think you didn't you apply D31941 in m-c first?
If customElements.get(...) was null all the toolbarbutton-menu-button custom element will not be set up and that would cause the problem in the screen shot.
Assignee | ||
Comment 6•5 years ago
|
||
Fixed the misalignment. The patch works find for me on linux. Needs m-c arc patch D31941
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 7•5 years ago
|
||
Comment 8•5 years ago
|
||
Try run with this patch and a few friends is still quite broken:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=2852e54c4f384a72a352db3b9555c5b715f8c6e2
Comment 9•5 years ago
|
||
I guess there is this bug also: https://bugzilla.mozilla.org/show_bug.cgi?id=1553778
Comment 10•5 years ago
|
||
Yes, that's part of the try push, as I said "... and a few friends".
Comment 11•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/b7c1cd832766
[de-xbl] convert toolbar.xml#menu-button binding to custom element. r=khushil
Updated•5 years ago
|
Comment 12•5 years ago
|
||
Description
•