Open Bug 1557505 Opened 5 years ago Updated 2 years ago

ECPoint_mul/ec_points_mul take a lot of time on Arm32

Categories

(NSS :: Libraries, defect, P3)

ARM
Android

Tracking

(Not tracked)

People

(Reporter: jesup, Unassigned)

References

(Blocks 1 open bug)

Details

(Keywords: perf, perf:pageload, Whiteboard: [geckoview:p2])

Attachments

(1 obsolete file)

This was from loading allrecipes.com. for a 720ms block of time on socket thread, most of it was spent in ECPoint_mul (and below) or ec_points_mul (and below); some was spent in ec25519 (bug 1550579).

The current logic is that if the compiler somehow uses gold rather than
BFD ld by default, we let it, but if it uses BFD ld, we default to lld.
When doing Android builds, the compiler finds the linker in the NDK, and
the default ld binary is gold. So we currently end up using fold for
Android builds.

Here, we change the logic such that we use lld when the default linker
the compiler uses is either BFD ld or gold. We can't go with "is not
lld" because the other possible kind, ld64, is what we actually want to
use on mac, since lld doesn't support mach-o fully just yet.

Comment on attachment 9070398 [details]
Bug 1557505 - Default to lld linker for local builds in more cases.

Revision D34040 was moved to bug 1557507. Setting attachment 9070398 [details] to obsolete.

Attachment #9070398 - Attachment is obsolete: true
Keywords: perf
Priority: -- → P3
Hardware: Unspecified → ARM
OS: Unspecified → Android
Whiteboard: [qf:p1:pageload][geckoview] → [qf:p1:pageload][geckoview:p2]

We spend 364ms total on a S7 arm64 device, https://share.firefox.dev/3aIYTjj. Although it's not in one big block so I'm inclined to say this is a qf:p3.

Whiteboard: [qf:p1:pageload][geckoview:p2] → [qf:p3:pageload][geckoview:p2]
Performance Impact: --- → P3
Keywords: perf:pageload
Whiteboard: [qf:p3:pageload][geckoview:p2] → [geckoview:p2]
Severity: normal → S3
Performance Impact: low → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: