The Node highlighter sometimes stays visible even if the node isn't hovered anymore
Categories
(DevTools :: Debugger, defect, P3)
Tracking
(firefox72 fixed)
Tracking | Status | |
---|---|---|
firefox72 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
Steps to reproduce
- Open the debugger
- Create a new watch expression with
document.body
- Quickly move over it and out with your mouse a few time
Actual results
There might be cases where the highlighter stays visible on the page, even if the user don't hover the node anymore (i.e. we have a Zombie Highlighter)
The same problem was fixed in the console in Bug 1358983. We should also use toolbox.js
's getHighlighter
to properly highlight nodes from the debugger.
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
So, the attached patch should fix the issue, and it seems to work when I test it manually.
However, I can't get the test to pass, as the node never unhighlight (with or without my fix in panel.js
).
I guess some part is related to Bug 1562165.
If I early return in WhyPaused
render function, at least I get the unhighlight
event I'm waiting for.
But, the highlighter is still visible, which is weird.
My guess is that some re-render is causing trouble? But I'm not sure about that.
It would be nice to get another pair of eyes on this, as I've been testing some things without figuring what's really going on.
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
Some panels, like the debugger, might handle both nodeFronts and grips
at the same time, so there's no way to know ahead of time which kind
of object we're going to deal with.
This patch remove the isGrip parameter, and perform a check on the
passed object to see if it's a nodeFront instance or not.
Depends on D48810
Comment 6•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ed351e41d3d5
https://hg.mozilla.org/mozilla-central/rev/8acdee03fb76
Description
•