Unaligned elements in the account manager
Categories
(MailNews Core :: Account Manager, defect)
Tracking
(thunderbird68 fixed, thunderbird69 fixed, thunderbird70 fixed)
People
(Reporter: aceman, Assigned: khushil324)
References
(Regression)
Details
(Keywords: regression)
Attachments
(3 files, 7 obsolete files)
(deleted),
image/png
|
Details | |
(deleted),
image/png
|
Details | |
(deleted),
patch
|
aceman
:
review+
jorgk-bmo
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
After removal of grid element in bug 1521483, some elements in the Account manager now do not align properly, the label and its corresponding textbox are not centered on the same line/row. See the attachments
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 5•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Comment 6•5 years ago
|
||
You could try to use a html:table like I did in Calendar/General.
Assignee | ||
Comment 7•5 years ago
|
||
Assignee | ||
Comment 8•5 years ago
|
||
You could try to use a html:table like I did in Calendar/General.
Yess, I have tried it with few of the de-grid tasks. Do you want it as a submitted patch or want to have as the html:table? I use hbox and vbox in trivial solutions. I generally use html:table, when we don't have any other options available.
Assignee | ||
Comment 10•5 years ago
|
||
Reporter | ||
Comment 11•5 years ago
|
||
Assignee | ||
Comment 12•5 years ago
|
||
Assignee | ||
Comment 13•5 years ago
|
||
(In reply to :aceman from comment #11)
Thanks. This seems to solve the vertical alignment of the elements.
But now the elements aren't packed to the left to use as low space as
needed. This is seen best on a NNTP server's Server settings pane, where
there is only "Connection Security" and its menulist is far right of it.
Is there an attribute on html table to make it NOT try to fill 100% of the
document width?
This low space between label and menulist/box is set up by table so I don't think we can do anything with that.
Why are these width:100% needed?
To make the textbox and menulist covering the remaining width of the dialogue box. We can have less width for menulist (like 75%) but I found 100% width looking good.
Reporter | ||
Comment 14•5 years ago
|
||
Assignee | ||
Comment 15•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Reporter | ||
Comment 16•5 years ago
|
||
Updated•5 years ago
|
Reporter | ||
Comment 17•5 years ago
|
||
Reporter | ||
Comment 18•5 years ago
|
||
I removed the width:200px, still looks good to me.
Updated•5 years ago
|
Comment 19•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/48e3344da003
fixed unaligned elements in the account manager. r=aceman
Updated•5 years ago
|
Comment 20•5 years ago
|
||
TB 68 beta 5:
https://hg.mozilla.org/releases/comm-beta/rev/bbc19c7449026616efc289158a968da7b3e7b390
TB 69 beta:
https://hg.mozilla.org/releases/comm-beta/rev/099ce2ae99a078da668f572217509fb2ab7f0e46
Description
•