Creating a new Chat account loses port number
Categories
(Thunderbird :: Instant Messaging, defect)
Tracking
(thunderbird68+ fixed, thunderbird69 fixed)
People
(Reporter: walts48, Assigned: aceman)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
While testing TB 68.0b3 rc (Buid1) with a fresh test profile on Windows 10 and Ubuntu 18.04.2.
Click Chat to create a new Chat account
Select IRC
Click Next
Enter the Username
Enter irc.mozilla.org for the Server
Click Next
Enter a Password
In the Advanced Options dialog, note that the Port is correct for having SSL selected
Click Finish to create the account
Note that in the Chat Account Wizard Summary the Port: is shown as false
Try connecting and you can't.
Checked the Error Console
"TypeError: this.imAccount is null
imIncomingServer.js:143:5
Connection closed by server. 5 irc.js:7"
Check the account in Account settings and see the Port is set to 0
Set the Port to the correct number for SSL enabled and can connect successfully.
No problem when updating from 68.0b2 to 68.0b3 using the already configured test profiles for b2.
Comment 1•5 years ago
|
||
https://dxr.mozilla.org/comm-beta/source/mail/components/im/imIncomingServer.js#143
Alice, can you please find the regression for us. I could easily reproduce it.
Comment 2•5 years ago
|
||
OK, when you look at the port in the account settings, you see 0 instead of 6697. If you change that manually to 6697, you can connect. So something went wrong in IM account creation.
Updated•5 years ago
|
Updated•5 years ago
|
Comment 3•5 years ago
|
||
I do not have any Username/Password for irc.
What should I do?
Comment 4•5 years ago
|
||
Invent something, it doesn't matter for account creation and the fact that the port is lost. Use alice/12345.
Comment 5•5 years ago
|
||
Regression window(the port # becomes 0):
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=70cded2918d3b83c273da5a55a72f91ce7b2a442&tochange=450a66aeeaa8bd80ee95808f2e4d1a274c7bcb14
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a8c21ee98a4c2f683335b8358c11b2fceb863f05&tochange=a8c21ee98a4c2f683335b8358c11b2fceb863f05
Comment 6•5 years ago
|
||
Thanks so much, Alice, that makes the search easier. Likely bug 1556868 again which already caused a few regressions.
The bug is at https://searchfox.org/comm-central/source/mail/components/im/content/imAccountWizard.js#366, it seems "checked" attribute exists on all <input> elements, regardless of type. So we were taking that branch, returning a value of 'false' for the 'port' box, ignoring the real port number that was in the "value" property.
(In reply to WaltS48 [:walts48] from comment #0)
"TypeError: this.imAccount is null
imIncomingServer.js:143:5
Connection closed by server. 5 irc.js:7"
This one is caused by trying to save the pref with name "canChangeStoreType" as bool in an imAccount.
This part is not fixed by my patch, please investigate further.
Comment 9•5 years ago
|
||
The JS message is a false lead, it already exists since TB 60, see bug 1562438.
The issue at hand is that the port number is lost.
Updated•5 years ago
|
Comment 10•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 11•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/b7fc532744f4
read element.checked only if the <input> element is a checkbox in IM account wizard. r=jorgk DONTBUILD
Comment 12•5 years ago
|
||
Updated•5 years ago
|
Comment 13•5 years ago
|
||
Well, as I said in comment #10, this still doesn't connect automatically any more.
I use all the default values: New profile, add chat account, IRC, xxx/chat.freenode.net, 3x Next, 1x Finish. Doesn't connect, but TB 60 does.
Before this change, I believe, it tried to connect, but failed, since the port was 0.
I debugged this a bit and at the line we changed saw types of blank, "number" and "password", I didn't see "checkbox".
Comment 14•5 years ago
|
||
dump(`=== ${elt.getAttribute("type")} ${("checked" in elt)} ${aId}\n`);
gives
=== password false password
=== false alias
=== number true prpl-irc-port
=== true prpl-irc-ssl
=== false prpl-irc-encoding
=== false prpl-irc-quitmsg
=== false prpl-irc-partmsg
=== true prpl-irc-showServerTab
=== false prpl-irc-alternateNicks
=== true connectNow
Comment 15•5 years ago
|
||
Comment 16•5 years ago
|
||
Assignee | ||
Comment 17•5 years ago
|
||
(In reply to Jorg K (GMT+2) from comment #13)
I debugged this a bit and at the line we changed saw types of blank, "number" and "password", I didn't see "checkbox".
True, the dialog uses <checkbox> for checkboxes, not <input type="checkbox">, so my patch fixed the type="number" boxes, but may have broken checkboxes :(
Assignee | ||
Comment 18•5 years ago
|
||
(In reply to Pulsebot from comment #15)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/7302ce3d1e78
Follow-up: Check for type number explicitly. r=me DONTBUILD
r=aceman for this fix, thanks :)
Description
•