Creating a new Chat account doesn't store the password in 71.0b1
Categories
(Thunderbird :: Instant Messaging, defect)
Tracking
(thunderbird71 fixed, thunderbird72 fixed)
People
(Reporter: walts48, Assigned: aceman)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
jorgk-bmo
:
review+
aceman
:
feedback+
jorgk-bmo
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1562314 +++
While testing TB 71.0b rc (Buid1) with a fresh test profile on Ubuntu 18.04.3.
Click Chat to create a new Chat account
Select IRC
Click Next
Enter the Username
Enter irc.mozilla.org for the Server
Click Next
Enter a Password
Click Next
Click Next in the Advanced Options dialog
Notice the 'Character Set' is set to UTF-8
Click Finish to create the account and connect
Notice the 'Character Set' is set to false.
What happens:
Account connects with a prompt from NickServ to verify the nick is yours by entering the password.
What should happen:
Account should connect without the prompt.
Clicking Show Accounts > Properties opens the account settings, and I noticed the password isn't saved and 'Character Set' is set to false.
Error console shows "TypeError: this.imAccount is nullimIncomingServer.js:163:5"
Comment 1•5 years ago
|
||
Alice, can you please check for us when that broke.
Comment 2•5 years ago
|
||
I checked 70b4 and I do not believe it is broken there.
This might be related to bug 1587054?
Reporter | ||
Comment 3•5 years ago
|
||
(In reply to Patrick Cloke [:clokep] from comment #2)
I checked 70b4 and I do not believe it is broken there.
This might be related to bug 1587054?
It wasn't broken in 70.0b4 when I tested that release candidate.
Comment 4•5 years ago
|
||
Even if account creation doesn't store the correct details, you can correct them later, right? That's what I did. So it's not a show-stopper.
Reporter | ||
Comment 5•5 years ago
|
||
(In reply to Jorg K (GMT+2) from comment #4)
Even if account creation doesn't store the correct details, you can correct them later, right? That's what I did. So it's not a show-stopper.
Yes, the user that creates a new account can correct them later.
Users updating from 770.0b4 should see no problem. I didn't when I tested updating from 70.0b4 to the 71.0b1 candidate.
Comment 6•5 years ago
|
||
(In reply to Jorg K (GMT+2) from comment #1)
Alice, can you please check for us when that broke.
I tried to create chat with fake username/password/server.
"Character Set : false" instead "Password: ****" in Summary section of "Chat Account Wizard" dialog.
And the username/password would not appear in Password Manager.
Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=a3a6442dde2fa53d263a561a8dc4845718f14318&tochange=7c55e731be1891f8e9d0dab13ca377fbd42bac6c
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6a36994d2e14869283ea43331eeeaedac5be9e7c&tochange=598d441e4ebaa93ab098d266035a396057c82129
Comment 7•5 years ago
|
||
Thank you so much, as always, Alice.
Comment 9•5 years ago
|
||
Sorry, looks like it's regressed by bug 1563122. Alex is away, so Khushil, can you please take a look.
Updated•5 years ago
|
Comment 11•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 12•5 years ago
|
||
Comment 13•5 years ago
|
||
Comment 14•5 years ago
|
||
This is what Aceman suggested via IRC.
Assignee | ||
Comment 15•5 years ago
|
||
Comment 16•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/f6f166242dfd
only use 'checked' on <checkbox> and <input type="checkbox"> to fix password storage on IM account creation. r=jorgk
Updated•5 years ago
|
Updated•5 years ago
|
Comment 17•5 years ago
|
||
Tested this only a custom built Thunderbird and the issue is fixed. Thanks Jorg/aceman!
Comment 18•5 years ago
|
||
TB 71 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/5d1330a8568eaa383089acf8f49d39e949455e79
Description
•