Closed Bug 1562922 Opened 5 years ago Closed 5 years ago

Implement the backend API for the default engine in private browsing mode

Categories

(Firefox :: Search, task, P2)

Product:
Firefox
Component:
Search
Type:
task
Points:
5

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 70
Iteration:
70.4 - Aug 19 - Sep 1
Tracking Flags:
Tracking Status
firefox70 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

Bug 1562922 - Implement handling a separate private default engine via nsISearchService.defaultPrivateEngine. r?daleharvey
(deleted), text/x-phabricator-request
Details
Bug 1562922 - Handle removing the currently set default private search engine. r?daleharvey
(deleted), text/x-phabricator-request
Details
Bug 1562922 - If the default private search engine is different to normal mode, it should default to second in the sorted list. r?daleharvey
(deleted), text/x-phabricator-request
Details
Bug 1562922 - Add more tests to ensure the private search engine is correctly loaded from settings. r?daleharvey
(deleted), text/x-phabricator-request
Details

Bug 1560424 added a dummy API for getting/setting the default engine for private browsing mode (which would get/set the normal default engine).

We now need to implement those so that they work as expected.

This bug needs to

  • Change the get/set to set the default engine for private browsing mode.
  • Obtain the default engine from list.json / the new search configuration.
  • Save the default in the cache.
  • Implement observer notifications
  • Implement a preference to always mirror the normal browsing mode, i.e. a fallback to turn the feature off, or for apps based on gecko/toolkit that don't want/need a separate default.
Blocks: 1563021
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Iteration: --- → 70.1 - Jul 8 - 21
Depends on: 1566117
Iteration: 70.1 - Jul 8 - 21 → ---
Iteration: --- → 70.2 - Jul 22 - Aug 4
Iteration: 70.2 - Jul 22 - Aug 4 → 70.3 - Aug 5 - 18
Depends on: 1572141

Note: I split out part of this into bug 1572141, as it made sense as a separate patch, and helps to get that landed and move this forward.

Blocks: 1575873

I just filed bug 1575873 which splits out a test for the notification of change of the default private search engine. It was slightly too complicated to fit into this bug, and also would mean adding private engine selection to ABSearch, which I don't really want to do at the moment, given search modernization is happening.

Attachment #9087200 - Attachment description: Bug 1562922 - Implement handling a separate private default engine via nsISearchService.defaultPrivateEngine. → Bug 1562922 - Implement handling a separate private default engine via nsISearchService.defaultPrivateEngine. r?daleharvey
Attachment #9087201 - Attachment description: Bug 1562922 - Handle removing the currently set default private search engine. → Bug 1562922 - Handle removing the currently set default private search engine. r?daleharvey
Iteration: 70.3 - Aug 5 - 18 → 70.4 - Aug 19 - Sep 1
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8d8222618be1 Implement handling a separate private default engine via nsISearchService.defaultPrivateEngine. r=daleharvey https://hg.mozilla.org/integration/autoland/rev/fd259cdfd3f1 Handle removing the currently set default private search engine. r=daleharvey https://hg.mozilla.org/integration/autoland/rev/93e8ce4c2a59 If the default private search engine is different to normal mode, it should default to second in the sorted list. r=daleharvey https://hg.mozilla.org/integration/autoland/rev/d4fa68b60829 Add more tests to ensure the private search engine is correctly loaded from settings. r=daleharvey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: