Document various SearchService properties, and switch SearchService._engines to be a Map
Categories
(Firefox :: Search, task, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(2 files)
SearchService has some undocumented properties that I've been struggling to understand what they are actually for. Now I've understood this, I want to get that documented.
Additionally, I noticed that _engines is really a Map rather than an object, and I think it makes more sense to access it as a Map, as well as making one or two things cleaner. Hence I'm working on a patch for that as well.
Assuming Shane's patch in bug 1556789 re-lands reasonably quickly, I want to land these after that. Hence posting as WIP at the moment, but will update once that lands.
|
Assignee | |
Comment 1•5 years ago
|
||
Shane tells me he's taking a break on that patch, so unblocking from that.
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D38233
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/e2118b9a9c2d
https://hg.mozilla.org/mozilla-central/rev/693494d80274
Description
•