Use HTML input instead of XUL textbox in mail/components/im/content/
Categories
(Thunderbird :: General, task)
Tracking
(Not tracked)
People
(Reporter: aleca, Assigned: aleca)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
aleca
:
review+
|
Details | Diff | Splinter Review |
- mail/components/im/content/addbuddy.xul
- mail/components/im/content/am-im.xul
- mail/components/im/content/chat-conversation-info.js
- mail/components/im/content/chat-messenger.inc.xul
- mail/components/im/content/imAccounts.xul
- mail/components/im/content/imAccountWizard.xul
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
The entire Chat tab and related dialogs should have all been de-textbox'ed.
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
maybe it would make sense to instead always have input-inline, but match it on
input[type="number"].input-inline ?
I think it's better to keep those separate and not use the same class.
The .input-inline
applies the necessary padding and margin for a text field that is not styled automatically.
The number field already comes with a default style, so we don't need those padding and margin declarations, and the .number-inline
class is only necessary for those edge cases where it's required for the number field to grow as wide as its parent container.
toggleAttribute("hidden", true);
This method works for input fields but doesn't for XUL label
elements as the default style expects a [hidden="true"]
match, while this method only applies a hidden=""
attribute.
I could use setAttribute("hidden", true);
instead just for the labels, which it works.
What do you think?
Comment 4•5 years ago
|
||
Yeah that works for me. Perhaps name it input-number-inline though
Assignee | ||
Comment 5•5 years ago
|
||
Awesome, thanks.
Updated and ready for a review.
Comment 6•5 years ago
|
||
Assignee | ||
Comment 7•5 years ago
|
||
Patch updated.
Try-run: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=7823c4d4f9c2a747a5523532b0754ac8061e8e99
Updated•5 years ago
|
Assignee | ||
Comment 8•5 years ago
|
||
a couple Z3 and X4 failures which I can't recreate locally.
Are those known?
Comment 9•5 years ago
|
||
X4 gives a suggestion, bug 1508520. I think I've seen test-message-header.js::test_clicking_star_opens_inline_contact_editor before. Not very frequent, no bug yet. Don't worry about them. Seen here before:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=fc2d525229e607e2ae04152cde5bd41ad6c31c9d&selectedJob=266010949
Comment 10•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/fc79ff4e0560
Use HTML input instead of XUL textbox in mail/components/im/content/. r=mkmelin
Updated•5 years ago
|
Description
•