about:logins is still slow to display all the login count is greater than 100
Categories
(Firefox :: about:logins, defect, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox70 | --- | fixed |
People
(Reporter: jaws, Assigned: jaws)
References
Details
(Whiteboard: [passwords:management] [skyline] )
Attachments
(4 files, 1 obsolete file)
Bug 1560447 added a new API that does batch decryption of all logins which improved the performance of loading about:logins but there is still 25ms spent in the parent process converting nsILoginInfo objects to plain vanilla JS objects.
getAllLoginsAsync can have an extra option that returns the stored logins as plain objects so they don't need to be deconstructed later.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
With returnPlainObjects
implemented, https://perfht.ml/2XNAnsc
Comment 2•5 years ago
|
||
title = title.replace(/^http(s)?:\/\//, "")
should be inside the catch
block since .host
should never contain the scheme. That may give you another speedup.
Comment 3•5 years ago
|
||
Moving the regular expressions outside of the function would also mean they would only be compiled once.
Assignee | ||
Comment 4•5 years ago
|
||
With display chunking of the login-list: https://perfht.ml/2XIvlgH
The last large chunk of time was spent doing layout of the 500 login-list-items. Moving this to a chunked layout where we do 50 items at a time takes longer overall but gives faster perceived performance by showing logins in the list in approximately 100ms versus waiting roughly 500ms when appending during with one fragment.
Assignee | ||
Comment 5•5 years ago
|
||
Assignee | ||
Comment 6•5 years ago
|
||
Assignee | ||
Comment 7•5 years ago
|
||
Assignee | ||
Comment 8•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 9•5 years ago
|
||
Each custom element had its own shadowRoot, duplicated instances of the style sheet, and localization root. This patch also moves to a single 'click' event listener on the list instead of one for each item.
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Comment 10•5 years ago
|
||
Comment 11•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/eac2cad57171
https://hg.mozilla.org/mozilla-central/rev/d9f8d63390ab
https://hg.mozilla.org/mozilla-central/rev/f8043220eb7e
https://hg.mozilla.org/mozilla-central/rev/5f1acc97b6cc
Updated•5 years ago
|
Updated•5 years ago
|
Description
•