Closed
Bug 1566813
Opened 5 years ago
Closed 5 years ago
[Protections Panel] Show a notSecure icon if it is an about:certerror page
Categories
(Firefox :: Site Identity, task, P3)
Firefox
Site Identity
Tracking
()
RESOLVED
FIXED
Firefox 71
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: timhuang, Assigned: timhuang)
References
Details
(Whiteboard: [skyline])
Attachments
(3 files)
No description provided.
Updated•5 years ago
|
Priority: -- → P3
Whiteboard: [privacy-panel][triage] → [skyline]
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → tihuang
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•5 years ago
|
||
Right now, the gIdentityHandler.refreshIdentityBlock() is gigantic. In
order to not hit the eslint assert 'complexity', we segregate this
function into two functions according to the functionalities. This
slightly improves the readability of this function.
Assignee | ||
Comment 2•5 years ago
|
||
This patch adds a new class 'certError' for the identity icon if it is
in the 'about:certerror' page. The identity icon will show a warning
lock icon if this class is present.
Depends on D45645
Assignee | ||
Comment 3•5 years ago
|
||
We add a new connection type 'cert-error-page' and will show a warning
lock icon for it.
Depends on D45646
Pushed by tihuang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/605c42da4f23
Part 1: Divide gIdentityHandler.refreshIdentityBlock(). r=johannh
https://hg.mozilla.org/integration/autoland/rev/9d2a58664ef2
Part 2: Show a warning lock icon as the identity icon if it is in a 'about:certerror' page. r=johannh
https://hg.mozilla.org/integration/autoland/rev/b2132eecf8d0
Part 3: Show a warning lock icon for the 'about:certerror' page in identity popup. r=johannh
Comment 5•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/605c42da4f23
https://hg.mozilla.org/mozilla-central/rev/9d2a58664ef2
https://hg.mozilla.org/mozilla-central/rev/b2132eecf8d0
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in
before you can comment on or make changes to this bug.
Description
•