Closed Bug 1575080 Opened 5 years ago Closed 4 years ago

Inconsistent secure icon on net error pages

Categories

(Firefox :: Site Identity, defect, P3)

defect

Tracking

()

VERIFIED FIXED
90 Branch
Tracking Status
firefox-esr78 --- wontfix
firefox88 --- wontfix
firefox89 --- wontfix
firefox90 --- verified

People

(Reporter: ehsan.akhgari, Assigned: asahai100, Mentored)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [privacy-panel][skyline])

Attachments

(2 files, 1 obsolete file)

Attached image Screenshot (deleted) —

The network timeout page shows an (i) icon in the address bar but an insecure icon in the security doorhanger.

Note that bug 1566813 deals with making cert error pages show up as insecure, so this is only for net error.

Priority: -- → P3
Summary: Inconsistent secure icon on error pages → Inconsistent secure icon on net error pages
Whiteboard: [privacy-panel][skyline]

:Ehsan, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Flags: needinfo?(ehsan)
No longer blocks: 1562881
Flags: needinfo?(ehsan)
Regressed by: 1562881
Assignee: nobody → asahai100
Mentor: prathikshaprasadsuman
Status: NEW → ASSIGNED

This patch adds a new class 'netErrorPage' and a new connection-type 'net-error-page' to show not secure icon on about:neterror page and for net error pages respectively.

(In reply to Anshul Sahai from comment #3)

Created attachment 9214054 [details]
Bug 1575080 - Showing not secure lock identity icon on net error pages. r=prathiksha

This patch adds a new class 'netErrorPage' and a new connection-type 'net-error-page' to show not secure icon on about:neterror page and for net error pages respectively.

Correction - This patch adds a new class 'netErrorPage' to show not-secure icon for about:neterror page.

Pushed by prathikshaprasadsuman@gmail.com: https://hg.mozilla.org/integration/autoland/rev/ea976ff8173e Showing not secure lock identity icon on net error pages. r=prathiksha
Flags: needinfo?(asahai100)
Flags: needinfo?(asahai100)
Attachment #9214054 - Attachment is obsolete: true
Attachment #9214054 - Attachment is obsolete: false
Attachment #9214054 - Attachment is obsolete: true
Pushed by jhofmann@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c4e8d314809b Changing the identity icon and the string inside the identity panel for net error pages. r=fluent-reviewers,johannh
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Regressions: 1710189
Flags: qe-verify+

Hello,
I have managed to reproduce the issue on an affected Nightly build 70.0a1 (2019-08-19), but only on Ubuntu 20.04
Confirming this issue as verified fixed on Ubuntu 20.04, Win 10x64 and macOS 10.15, using Firefox 90.0b2 (2021-06-01).
Thanks!

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: