Closed Bug 1566850 Opened 5 years ago Closed 5 years ago

Convert `target.activeConsole` to `target.getFront("console")`

Tracking

(Fission Milestone:M6, firefox73 fixed)

Status:

RESOLVED FIXED

Milestone:

Firefox 73

Project Flags:

Fission Milestone

Tracking Flags:

Tracking

Status

firefox73

---

fixed

People

(Reporter: ochameau, Assigned: nchevobbe)

References

Details

(Whiteboard: dt-fission-m1)

Attachments

(8 files, 1 obsolete file)

Bug 1566850 - Remove target.activeConsole usage in Console. r=ochameau. 5 years ago Nicolas Chevobbe [:nchevobbe] (deleted), text/x-phabricator-request		Details
Bug 1566850 - Remove target.activeConsole usage in DOM panel. r=miker. 5 years ago Nicolas Chevobbe [:nchevobbe] (deleted), text/x-phabricator-request		Details
Bug 1566850 - Remove target.activeConsole usage in tests. r=ochameau. 5 years ago Nicolas Chevobbe [:nchevobbe] (deleted), text/x-phabricator-request		Details
Bug 1566850 - Remove target.activeConsole usage in Netmonitor. r=Honza. 5 years ago Nicolas Chevobbe [:nchevobbe] (deleted), text/x-phabricator-request		Details
Bug 1566850 - Remove target.activeConsole usage in Debugger. r=jlast. 5 years ago Nicolas Chevobbe [:nchevobbe] (deleted), text/x-phabricator-request		Details
Bug 1566850 - Remove target.activeConsole usage in WebConsole. r=ochameau. 5 years ago Nicolas Chevobbe [:nchevobbe] (deleted), text/x-phabricator-request		Details
Bug 1566850 - Remove target.activeConsole usage in Toolbox. r=ochameau. 5 years ago Nicolas Chevobbe [:nchevobbe] (deleted), text/x-phabricator-request		Details
Bug 1566850 - Remove this.activeConsole in TargetMixin. r=ochameau. 5 years ago Nicolas Chevobbe [:nchevobbe] (deleted), text/x-phabricator-request		Details
Bug 1566850 - Remove target.activeConsole usage in devtools extension code. r=jdescottes. 5 years ago Nicolas Chevobbe [:nchevobbe] (deleted), text/x-phabricator-request		Details

Alexandre Poirot [:ochameau]

Reporter

Description

•

5 years ago

ThreadFront and WebConsoleFront are the only two one left having a special codepath in TargetMixin.
These two are special as there is synchronous attributes on the target object, activeConsole and threadFront, in order to get a reference to them.
Their instantiation is also special as you have to call target.attachConsole as well as target.attachThread in order to create these attributes.
There is some discrepancies between these two and all the other one which are created on-demand on the first call to target.getFront:

target.attachConsole is called in middle of target.attach, manually, from each target subclasses:
https://searchfox.org/mozilla-central/search?q=this.attachConsole(&case=false&regexp=false&path=shared%2Ffronts%2Ftargets%2F
target.attachThread is called from many various callsites:
https://searchfox.org/mozilla-central/search?q=.attachThread(&case=false&regexp=false&path=
But the two important callsites if we ignore tests are:
- the toolbox open function
  https://searchfox.org/mozilla-central/rev/22b330ecb3edba1536a54887060cbdd09db21c59/devtools/client/framework/toolbox.js#638-647
- the debugger updateWorkers
  https://searchfox.org/mozilla-central/source/devtools/client/debugger/src/client/firefox/workers.js#35-41

In any case, we should distinguish the two following operation:

retrieving the front: target.getFront("xxx")
"attaching it": console.startListeners([]) and thread.attach(options)

A first iteration would be to do this split and use target.getFront everywhere.
Then, we could possibly iterate in order to cleanup the various way we are "attaching" these actors.

Why is this important to switch to getFront?

enable target.onFront to work with these two fronts. Fission is going to force us to support more than one front instance. In a near future, we are going to replace a few calls to getFront into calls to onFront. This step will be easier if we are already using getFront.
having a unified codebase. There is no reason but historical ones to have specifics around these two fronts.

Nicolas Chevobbe [:nchevobbe]

Assignee

Updated

•

5 years ago

Priority: -- → P1

Nicolas Chevobbe [:nchevobbe]

Assignee

Updated

•

5 years ago

Assignee: nobody → nchevobbe

Status: NEW → ASSIGNED

Nicolas Chevobbe [:nchevobbe]

Assignee

Comment 1

•

5 years ago

Attached file Bug 1566850 - Remove target.activeConsole usage in Console. r=ochameau. (obsolete) (deleted) — Details

Depends on D39471

Nicolas Chevobbe [:nchevobbe]

Assignee

Comment 2

•

5 years ago

Attached file Bug 1566850 - Remove target.activeConsole usage in DOM panel. r=miker. (deleted) — Details

Depends on D56685

Nicolas Chevobbe [:nchevobbe]

Assignee

Comment 3

•

5 years ago

Attached file Bug 1566850 - Remove target.activeConsole usage in tests. r=ochameau. (deleted) — Details

Depends on D56686

Nicolas Chevobbe [:nchevobbe]

Assignee

Comment 4

•

5 years ago

Attached file Bug 1566850 - Remove target.activeConsole usage in Netmonitor. r=Honza. (deleted) — Details

Depends on D56688

Nicolas Chevobbe [:nchevobbe]

Assignee

Comment 5

•

5 years ago

Attached file Bug 1566850 - Remove target.activeConsole usage in Debugger. r=jlast. (deleted) — Details

Depends on D56689

Nicolas Chevobbe [:nchevobbe]

Assignee

Comment 6

•

5 years ago

Attached file Bug 1566850 - Remove target.activeConsole usage in WebConsole. r=ochameau. (deleted) — Details

Depends on D56690

Nicolas Chevobbe [:nchevobbe]

Assignee

Comment 7

•

5 years ago

Attached file Bug 1566850 - Remove target.activeConsole usage in Toolbox. r=ochameau. (deleted) — Details

Depends on D56691

Nicolas Chevobbe [:nchevobbe]

Assignee

Comment 8

•

5 years ago

Attached file Bug 1566850 - Remove this.activeConsole in TargetMixin. r=ochameau. (deleted) — Details

Depends on D56692

Phabricator Automation

Updated

•

5 years ago

Attachment #9115100 - Attachment description: Bug 1566850 - Remove target.activeConsole usage in DOM panel. r=ochameau. → Bug 1566850 - Remove target.activeConsole usage in DOM panel. r=miker.

Phabricator Automation

Updated

•

5 years ago

Attachment #9115104 - Attachment description: Bug 1566850 - Remove target.activeConsole usage in Netmonitor. r=ochameau. → Bug 1566850 - Remove target.activeConsole usage in Netmonitor. r=Honza.

Phabricator Automation

Updated

•

5 years ago

Attachment #9115106 - Attachment description: Bug 1566850 - Remove target.activeConsole usage in Debugger. r=ochameau. → Bug 1566850 - Remove target.activeConsole usage in Debugger. r=jlast.

Nicolas Chevobbe [:nchevobbe]

Assignee

Comment 9

•

5 years ago

TRY looks okay: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b14df15d4f00189809d951fec3c89ed4ffc580c0

Pulsebot

Comment 10

•

5 years ago

Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1796a39b020b Remove target.activeConsole usage in DOM panel. r=ochameau. https://hg.mozilla.org/integration/autoland/rev/33c4706a4255 Remove target.activeConsole usage in tests. r=ochameau. https://hg.mozilla.org/integration/autoland/rev/55ac64d74725 Remove target.activeConsole usage in Netmonitor. r=Honza. https://hg.mozilla.org/integration/autoland/rev/4deadf97378f Remove target.activeConsole usage in Debugger. r=jlast. https://hg.mozilla.org/integration/autoland/rev/3c8ef35fde92 Remove target.activeConsole usage in WebConsole. r=ochameau. https://hg.mozilla.org/integration/autoland/rev/b3aea303d3ed Remove target.activeConsole usage in Toolbox. r=ochameau. https://hg.mozilla.org/integration/autoland/rev/da1672f831d1 Remove this.activeConsole in TargetMixin. r=ochameau.

Stefan Hindli [:stefan_hindli]

Comment 11

•

5 years ago

Backed out 8 changesets (Bug 1566850, Bug 1603035) for causing perma bc failures in browser/components/extensions/test/browser/browser_ext_devtools_inspectedWindow.js CLOSED TREE

https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=281034751

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=281034751&repo=autoland&lineNumber=8474

Flags: needinfo?(nchevobbe)

Pulsebot

Comment 12

•

5 years ago

Backout by shindli@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/535b50b4c504 Backed out 8 changesets (bug 1566850, bug 1603035) for causing perma bc failures in browser/components/extensions/test/browser/browser_ext_devtools_inspectedWindow.js CLOSED TREE

Nicolas Chevobbe [:nchevobbe]

Assignee

Comment 13

•

5 years ago

urgh sorry, missed on call site

Flags: needinfo?(nchevobbe)

Nicolas Chevobbe [:nchevobbe]

Assignee

Comment 14

•

5 years ago

Attached file Bug 1566850 - Remove target.activeConsole usage in devtools extension code. r=jdescottes. (deleted) — Details

Depends on D56692

Chris Peterson [:cpeterson]

Comment 15

•

5 years ago

Tracking Fission DevTools bugs for Fission Nightly (M6)

Fission Milestone: --- → M6

Pulsebot

Comment 16

•

5 years ago

Pushed by nchevobbe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b043364b1636 Remove target.activeConsole usage in DOM panel. r=ochameau. https://hg.mozilla.org/integration/autoland/rev/63f43d73d53a Remove target.activeConsole usage in tests. r=ochameau. https://hg.mozilla.org/integration/autoland/rev/368e030bee6e Remove target.activeConsole usage in Netmonitor. r=Honza. https://hg.mozilla.org/integration/autoland/rev/75e1e143cd8d Remove target.activeConsole usage in Debugger. r=jlast. https://hg.mozilla.org/integration/autoland/rev/ad57ea430417 Remove target.activeConsole usage in WebConsole. r=ochameau. https://hg.mozilla.org/integration/autoland/rev/6bb8f7988396 Remove target.activeConsole usage in Toolbox. r=ochameau. https://hg.mozilla.org/integration/autoland/rev/8d07872ee7aa Remove target.activeConsole usage in devtools extension code. r=jdescottes,rpl. https://hg.mozilla.org/integration/autoland/rev/0f7053d36328 Remove this.activeConsole in TargetMixin. r=ochameau.

Marco Mucci [:MarcoM]

Updated

•

5 years ago

Whiteboard: dt-fission-m1

Cristina Coroiu [:ccoroiu]

Comment 17

•

5 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/b043364b1636
https://hg.mozilla.org/mozilla-central/rev/63f43d73d53a
https://hg.mozilla.org/mozilla-central/rev/368e030bee6e
https://hg.mozilla.org/mozilla-central/rev/75e1e143cd8d
https://hg.mozilla.org/mozilla-central/rev/ad57ea430417
https://hg.mozilla.org/mozilla-central/rev/6bb8f7988396
https://hg.mozilla.org/mozilla-central/rev/8d07872ee7aa
https://hg.mozilla.org/mozilla-central/rev/0f7053d36328

Status: ASSIGNED → RESOLVED

Closed: 5 years ago

status-firefox73: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → Firefox 73

Phabricator Automation

Updated

•

5 years ago

Attachment #9081187 - Attachment is obsolete: true

Nicolas Chevobbe [:nchevobbe]

Assignee

Updated

•

5 years ago

See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=1618015

You need to log in before you can comment on or make changes to this bug.