Closed
Bug 1485383
Opened 6 years ago
Closed 5 years ago
Use target.getFront to instantiate all target-scoped actor fronts
Categories
(DevTools :: Framework, enhancement, P1)
DevTools
Framework
Tracking
(firefox71 fixed)
RESOLVED
FIXED
Firefox 71
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: ochameau, Assigned: yulia)
References
(Depends on 2 open bugs, Blocks 1 open bug)
Details
(Whiteboard: dt-fission-m1)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
There is still a couple of places where we instanciate the fronts manually:
* InspectorActor:
=> Dedicated bug 1485374, causes specific troubles and justify its own bug.
* CallWatcherFront:
=> Dedicated bug 1485378, it isn't a real actor and do not need a front.
* CanvasFront:
https://searchfox.org/mozilla-central/search?q=CanvasFront(&case=false®exp=false&path=
* WebGLFront:
https://searchfox.org/mozilla-central/search?q=WebGLFront(&case=false®exp=false&path=
* WebAudioFront:
https://searchfox.org/mozilla-central/search?q=WebGLFront(&case=false®exp=false&path=
* StyleSheetsFront:
https://searchfox.org/mozilla-central/search?q=WebGLFront(&case=false®exp=false&path=
* StorageFront:
https://searchfox.org/mozilla-central/search?q=WebGLFront(&case=false®exp=false&path=
* MemoryFront:
https://searchfox.org/mozilla-central/search?q=WebGLFront(&case=false®exp=false&path=
* FramerateFront:
It is similar to CallWatcher. It isn't used by the frontend, but only by the test. It isn't really a target scoped actor, only for the test. For the frontend perspective this is only an internal call of the timeline actor. The FramerateActor isn't used anywhere, it is only used by the tests.
https://searchfox.org/mozilla-central/search?q=FramerateActor(&case=false®exp=false&path=
https://searchfox.org/mozilla-central/search?q=FramerateFront&case=false®exp=false&path=
* ReflowFront:
https://searchfox.org/mozilla-central/search?q=ReflowFront(&case=false®exp=false&path=
* CssPropertiesFront:
https://searchfox.org/mozilla-central/search?q=CssPropertiesFront(&case=false®exp=false&path=
This one is interesting as if we drop the compatibility layer, we may be able to drop this intermediate piece of code that was doing memoization.
* CSSUsageFront:
https://searchfox.org/mozilla-central/search?q=CssUsageFront(&case=false®exp=false&path=
This ony is also interesting as it workaround makeRemote while trying to memoize.
* TimelineFront:
https://searchfox.org/mozilla-central/search?q=TimelineFront(&case=false®exp=false&path=
Note that this actor/front is only used for backward compat with <FF45!
* PerformanceFront:
https://searchfox.org/mozilla-central/search?q=PerformanceFront(&case=false®exp=false&path=
Only tests as bug 1222047 already refactored production callsites. It may be useful to migrate initPerformance/destroyPerformance pieces to fronts.
https://searchfox.org/mozilla-central/rev/3fa761ade83ed0b8ab463acb057c2cf0b104689e/devtools/client/framework/toolbox.js#3087-3116
* AnimationsFront:
https://searchfox.org/mozilla-central/search?q=animationsfront(&case=false®exp=false&path=
* PromisesFront:
https://searchfox.org/mozilla-central/search?q=PromisesFront(&case=false®exp=false&path=
Only used by test, we may try to remove this actor/front?
* EmulationFront:
https://searchfox.org/mozilla-central/search?q=EmulationFront(&case=false®exp=false&path=
* WebExtensionInspectedWindowFront:
https://searchfox.org/mozilla-central/search?q=WebExtensionInspectedWindowFront(&case=false®exp=false&path=
* AccessibilityFront:
https://searchfox.org/mozilla-central/search?q=AccessibilityFront(&case=false®exp=false&path=
Reporter | ||
Updated•6 years ago
|
Summary: Use target.getFront to instanciate all target-scoped actor fronts → Use target.getFront to instantiate all target-scoped actor fronts
Assignee | ||
Updated•6 years ago
|
Blocks: dt-fission
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → ystartsev
Reporter | ||
Updated•6 years ago
|
Whiteboard: dt-fission
Assignee | ||
Updated•6 years ago
|
No longer blocks: dt-fission
Assignee | ||
Updated•5 years ago
|
Blocks: dt-fission-framework
Assignee | ||
Comment 1•5 years ago
|
||
It looks like this is mostly done. this is the remaining issue:
Emulation front: https://searchfox.org/mozilla-central/search?q=EmulationFront(&case=false®exp=false&path
Assignee | ||
Updated•5 years ago
|
Status: NEW → ASSIGNED
Priority: P2 → P1
Assignee | ||
Comment 2•5 years ago
|
||
Pushed by ystartsev@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a679cbe3aac3
update emulationFront to be retrieved using getFront; r=jdescottes
Comment 4•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Updated•5 years ago
|
Whiteboard: dt-fission → dt-fission dt-fission-m1
Updated•3 years ago
|
Whiteboard: dt-fission dt-fission-m1 → dt-fission-m1
You need to log in
before you can comment on or make changes to this bug.
Description
•