remove grid usage from comm/mailnews/base/content/msgAccountCentral.xul
Categories
(Thunderbird :: General, task)
Tracking
(Not tracked)
People
(Reporter: khushil324, Assigned: khushil324)
References
Details
Attachments
(1 file, 5 obsolete files)
(deleted),
patch
|
khushil324
:
review+
|
Details | Diff | Splinter Review |
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 2•5 years ago
|
||
Comment 3•5 years ago
|
||
I think for the classes, use lower case names with dashes.
Assignee | ||
Comment 4•5 years ago
|
||
Comment 5•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Comment 6•5 years ago
|
||
What's the point of all this code churn? You wanted to replace grids and started renaming an awful lot of identifiers. I can't see the forest for the trees. If you really must do that, split it into two patches.
Magnus, is this really necessary?
Comment 7•5 years ago
|
||
I blame aleca ;)
Anyway, the capitalized ids were very ugly so let's just go with what we got.
I notice now, there were some ids with dots in them (like offlineSettings.spacer), please fix that (->offlineSettingsSpacer)
Comment 8•5 years ago
|
||
As per the discussion on "atomic" changes: Let's not throw the essential part of grid removal into the same patch as the wholesale renaming. I hope you didn't miss anything.
Comment 9•5 years ago
|
||
Yes but it's already done now and splitting it up would be pretty pointless.
Assignee | ||
Comment 10•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Comment 11•5 years ago
|
||
I'm splitting this now as I had requested. Took less than 30 minutes.
Comment 12•5 years ago
|
||
These are the net XUL changes. Wholesale rename will be in a second patch.
Comment 13•5 years ago
|
||
Here's the rename part.
Why are we using different styles for IDs and classed, looks terrible :-( - like:
- <spacer id="SubscribeImapFolders.spacer" flex="1" collapsed="true"/>
- <hbox id="SubscribeImapFolders" class="acctCentralRow" collapsed="true">
+ <spacer id="subscribeImapFoldersSpacer" flex="1" collapsed="true"/>
+ <hbox id="subscribeImapFolders" class="acct-central-row" collapsed="true">
Assignee | ||
Comment 14•5 years ago
|
||
Assignee | ||
Comment 15•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Comment 16•5 years ago
|
||
(In reply to Khushil Mistry [:khushil324] from comment #14)
Let me add the two seprate patches.
That's what I asked for in comment #6 :-) - Sorry I got the CSS distribution wrong.
Comment 17•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/9f87d233392f
remove grid usage from msgAccountCentral.xul. r=mkmelin
Updated•5 years ago
|
Description
•