Closed
Bug 1568321
Opened 5 years ago
Closed 5 years ago
remove grid usage from comm/calendar/resources/content/publishDialog.xul
Categories
(Thunderbird :: General, task)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 70.0
People
(Reporter: khushil324, Assigned: khushil324)
References
Details
Attachments
(1 file, 4 obsolete files)
(deleted),
patch
|
pmorris
:
review+
mkmelin
:
feedback+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → khushil324
Status: NEW → ASSIGNED
Assignee | ||
Updated•5 years ago
|
Blocks: tb-burn-xul-grids
Comment 2•5 years ago
|
||
Comment on attachment 9080167 [details] [diff] [review] Bug-1568321_remove-grid-publishDialog.patch Review of attachment 9080167 [details] [diff] [review]: ----------------------------------------------------------------- Please update this to use the grid-layout.css file and classes
Attachment #9080167 -
Flags: feedback?(mkmelin+mozilla)
Assignee | ||
Comment 3•5 years ago
|
||
Attachment #9080167 -
Attachment is obsolete: true
Attachment #9083779 -
Flags: feedback?(mkmelin+mozilla)
Comment 4•5 years ago
|
||
Comment on attachment 9083779 [details] [diff] [review] Bug-1568321_remove-grid-publishDialog.patch Review of attachment 9083779 [details] [diff] [review]: ----------------------------------------------------------------- Some bitrot, but... sorry to move the goal posts. I think the dialog should not have the description like it had, it's looking very old-fashioned. Please change the thing input to <html:input type="url" placeholder="&calendar.publish.example.url.description".> and remove the div with the description. This will also make the structure much cleaner and you don't even need grid layout.
Attachment #9083779 -
Flags: feedback?(mkmelin+mozilla)
Assignee | ||
Comment 5•5 years ago
|
||
Attachment #9083779 -
Attachment is obsolete: true
Attachment #9084893 -
Flags: feedback?(mkmelin+mozilla)
Comment 6•5 years ago
|
||
Comment on attachment 9084893 [details] [diff] [review] Bug-1568321_remove-grid-publishDialog-xul.patch Review of attachment 9084893 [details] [diff] [review]: ----------------------------------------------------------------- ::: calendar/resources/content/publishDialog.xul @@ +18,4 @@ > windowtype="Calendar:PublishDialog" > buttons="accept,cancel" > onload="loadCalendarPublishDialog()" > + persist="screenX screenY width" Why persist the width? I'd think we don't want that. @@ +44,5 @@ > + <label control="publish-remotePath-textbox">&calendar.publish.url.label;</label> > + </hbox> > + <hbox flex="1"> > + <label value=""/> > + </hbox> huh? seems rather pointless, no? @@ +49,5 @@ > + </vbox> > + <vbox flex="1"> > + <html:input id="publish-remotePath-textbox" oninput="checkURLField()"/> > + <html:input class="publish-example-url" type="url" value="&calendar.publish.example.url.description;" > + readonly="readonly"/> I think you misunderstood, it's the publish-remotePath-textbox input that would be type=url, and have the placeholder @@ +56,2 @@ > <html:progress id="publish-progressmeter" value="0" max="100"/> > + </vbox> <!-- dialog-box --> we can remove this comment, and the one befor the start too; dialogOverlay.xul is long gone
Attachment #9084893 -
Flags: feedback?(mkmelin+mozilla) → feedback-
Assignee | ||
Comment 7•5 years ago
|
||
Attachment #9084893 -
Attachment is obsolete: true
Attachment #9084986 -
Flags: feedback?(mkmelin+mozilla)
Comment 8•5 years ago
|
||
Made some changes.
Attachment #9084986 -
Attachment is obsolete: true
Attachment #9084986 -
Flags: feedback?(mkmelin+mozilla)
Attachment #9085006 -
Flags: review?(paul)
Attachment #9085006 -
Flags: feedback+
Comment 9•5 years ago
|
||
Comment on attachment 9085006 [details] [diff] [review] Bug-1568321_remove-grid-publishDialog-xul.patch Review of attachment 9085006 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. Nice simplification by removing the grid which isn't really needed here.
Attachment #9085006 -
Flags: review?(paul) → review+
Assignee | ||
Updated•5 years ago
|
Keywords: checkin-needed
Comment 10•5 years ago
|
||
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/7cf061e5e723
remove grid usage from publishDialog.xul. r=mkmelin,pmorris
Comment 11•5 years ago
|
||
No try run, I hope this doesn't blow up ;-)
Target Milestone: --- → Thunderbird 70.0
You need to log in
before you can comment on or make changes to this bug.
Description
•