Closed
Bug 1568825
Opened 5 years ago
Closed 5 years ago
Prepare the node-picker for being able to eventually select elements across targets
Categories
(DevTools :: Inspector, enhancement, P1)
DevTools
Inspector
Tracking
(firefox70 fixed)
RESOLVED
FIXED
Firefox 70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: pbro, Assigned: pbro)
References
(Blocks 1 open bug)
Details
(Whiteboard: dt-fission-m1)
Attachments
(3 files)
With Fission, the element picker in the toolbox should be able to pick elements that are inside oop frames (or remote browsers in the context of the browser toolbox).
For this to be possible, we need to first prepare the node-picker module in a way that it can easily be made multi-target-aware.
|
||
Updated•5 years ago
|
Priority: P3 → P2
Whiteboard: dt-fission
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D41596
|
|
||
Updated•5 years ago
|
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Priority: P2 → P1
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D41597
|
|
Assignee | |
Comment 4•5 years ago
|
||
|
||
Comment 5•5 years ago
|
||
I ended up rebasing the patches since I was kinda blocked on them.
Pushed by gluong@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/515ff404fcfe 1 - Moving node-picker.js to the client r=gl https://hg.mozilla.org/integration/autoland/rev/36627f38d627 2 - Moving the nodePicker singleton to the toolbox r=gl https://hg.mozilla.org/integration/autoland/rev/e1193c2352a1 3 - Remove the nodePicker's dependency on highlighter and walker r=gl
|
|
Assignee | |
Updated•5 years ago
|
Summary: Make it possible for the element picker to select elements also in oop frames → Prepare the node-picker for being able to eventually select elements across targets
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/515ff404fcfe
https://hg.mozilla.org/mozilla-central/rev/36627f38d627
https://hg.mozilla.org/mozilla-central/rev/e1193c2352a1
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
|
||
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
Whiteboard: dt-fission → dt-fission dt-fission-m1
|
|
||
Updated•3 years ago
|
Whiteboard: dt-fission dt-fission-m1 → dt-fission-m1
You need to log in
before you can comment on or make changes to this bug.
Description
•