Make it possible for the element picker to select elements also in oop frames
Categories
(DevTools :: Inspector, enhancement, P1)
Tracking
(firefox71 fixed)
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: pbro, Assigned: pbro)
References
(Blocks 1 open bug)
Details
(Whiteboard: dt-fission-m1)
Attachments
(5 files, 3 obsolete files)
With Fission, the element picker in the toolbox should be able to pick elements that are inside oop frames (or remote browsers in the context of the browser toolbox).
Once bug 1568825 lands, and once we get the right APIs to iterate over remote targets that we care about, then it should be easy to start the pick in all these targets at once.
2 things to solve though:
- there will be N pickers at once, which means we will need to find a way to hide all highlighters but the one corresponding to the target that the user is currently hovering
- mouse events in a parent target will block mouse events in a nested target (e.g. sub-iframe), so we will need to fix this so it doesn't happen.
Assignee | ||
Comment 1•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
Not working more on this at the moment beyond this early exploration. This is also blocked by bug 1574159.
Comment 3•5 years ago
|
||
Comment 4•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/35927e08a557 allow DevTools to access BrowsingContext; r=ochameau
Comment 6•5 years ago
|
||
bugherder |
Comment 7•5 years ago
|
||
- send a disconnectednode with getEmbedderElement
- fix pagestyle error;
Depends on D44133
Comment 8•5 years ago
|
||
Updated•5 years ago
|
Comment 9•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 12•5 years ago
|
||
Comment on attachment 9091761 [details]
Bug 1574401 - add targetFront and parentFront to target fronts
Revision D45366 was moved to bug 1584107. Setting attachment 9091761 [details] to obsolete.
Comment 13•5 years ago
|
||
Comment on attachment 9089334 [details]
Bug 1574401 - allow reparenting
Revision D44133 was moved to bug 1585567. Setting attachment 9089334 [details] to obsolete.
Comment 14•5 years ago
|
||
Comment on attachment 9091765 [details]
Bug 1574401 - remove nodeFront's connectToFrame
Revision D45368 was moved to bug 1585567. Setting attachment 9091765 [details] to obsolete.
Comment 15•5 years ago
|
||
Comment on attachment 9091762 [details]
Bug 1574401 - move listRemoteFrame from targets to mainRoot and descriptors
Revision D45367 was moved to bug 1585567. Setting attachment 9091762 [details] to obsolete.
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Comment 16•5 years ago
|
||
Pushed by ystartsev@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a046846a0789 move listRemoteFrame from targets to mainRoot and descriptors r=jdescottes,ochameau https://hg.mozilla.org/integration/autoland/rev/103be18558b0 remove nodeFront's connectToFrame r=ochameau https://hg.mozilla.org/integration/autoland/rev/354623d3c0be allow reparenting r=rcaliman,ochameau
Comment 17•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a046846a0789
https://hg.mozilla.org/mozilla-central/rev/103be18558b0
https://hg.mozilla.org/mozilla-central/rev/354623d3c0be
Comment 18•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a046846a0789
https://hg.mozilla.org/mozilla-central/rev/103be18558b0
https://hg.mozilla.org/mozilla-central/rev/354623d3c0be
Assignee | ||
Comment 19•5 years ago
|
||
Thank you so much Yulia for figuring these required pieces and pushing through with landing them. I'll take it back from here and attempt to land the final part (starting the node picker in all remote frames).
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 20•5 years ago
|
||
Pushed by pbrosset@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0a2d9956b5b4 Multi-target node-picker in the browser toolbox r=rcaliman,gl,ochameau
Comment 21•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Updated•3 years ago
|
Description
•