Implement feature promotion doorhangers using CFR
Categories
(Firefox :: Protections UI, task, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: xeonchen, Assigned: xeonchen)
References
(Blocks 1 open bug, )
Details
(Whiteboard: [skyline] [stp])
Attachments
(6 files, 4 obsolete files)
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
Comment 5•5 years ago
|
||
A couple of questions:
- Is this supposed to target 70, as the whiteboard seems to point to? This seems way too late.
- What's the reference one-pager? I'm only aware of the User Journey one, and STP CFR was descoped.
Assignee | ||
Comment 6•5 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #5)
A couple of questions:
- Is this supposed to target 70, as the whiteboard seems to point to? This seems way too late.
We’ve got an implementation on v70, this bug is a follow-up to re-implement using CFR.
- What's the reference one-pager? I'm only aware of the User Journey one, and STP CFR was descoped.
Tony, could you help with this question?
Assignee | ||
Comment 7•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 8•5 years ago
|
||
Updated•5 years ago
|
(In reply to Francesco Lodolo [:flod] from comment #5)
A couple of questions:
- Is this supposed to target 70, as the whiteboard seems to point to? This seems way too late.
- What's the reference one-pager? I'm only aware of the User Journey one, and STP CFR was descoped.
Hi Flod,
This bug is to migrate the existing Feature Promotion that the team already landed on 70 to the CFR rail.
The heuristics are in the design specs. And there is no UI change for this migration work.
https://mozilla.invisionapp.com/d/main#/console/17296602/373229713/preview
This is a fast follow post 70 whenever the patch is ready.
And you're right the user journey one was descoped. I just close the bug to avoid the confusion.
https://mozilla.invisionapp.com/d/main#/console/17296602/373229713/preview
Cindy
(In reply to Gary Chen [:xeonchen] from comment #6)
(In reply to Francesco Lodolo [:flod] from comment #5)
A couple of questions:
- Is this supposed to target 70, as the whiteboard seems to point to? This seems way too late.
We’ve got an implementation on v70, this bug is a follow-up to re-implement using CFR.
- What's the reference one-pager? I'm only aware of the User Journey one, and STP CFR was descoped.
Tony, could you help with this question?
Hi Flod,
This bug is to migrate the existing Feature Promotion that the team already landed on 70 to the CFR rail.
The heuristics are in the design specs. And there is no UI change for this migration work.
https://mozilla.invisionapp.com/d/main#/console/17296602/373229713/preview
This is a fast follow post 70 whenever the patch is ready.
And you're right the user journey one was descoped. I just close the bug to avoid the confusion.
https://mozilla.invisionapp.com/d/main#/console/17296602/373229713/preview
Cindy
Assignee | ||
Comment 10•5 years ago
|
||
Assignee | ||
Comment 11•5 years ago
|
||
Assignee | ||
Comment 12•5 years ago
|
||
- make
popupIconURL
support icon for dark theme - support
recommendation.anchorId
- support
recommendation.skipAddressBarNotifier
Assignee | ||
Comment 13•5 years ago
|
||
- make larger icon in popup optional
- add
data-notification-bucket
to support CSS on specific element - set CSS for
CFR_SOCIAL_TRACKING_PROTECTION
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 14•5 years ago
|
||
Comment 15•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4ad27f27eb86
https://hg.mozilla.org/mozilla-central/rev/5e87be03a7a1
https://hg.mozilla.org/mozilla-central/rev/6b93718550af
https://hg.mozilla.org/mozilla-central/rev/cb70d2019301
https://hg.mozilla.org/mozilla-central/rev/94c10676584a
https://hg.mozilla.org/mozilla-central/rev/26009ef5fd47
Updated•5 years ago
|
Description
•