Closed
Bug 1570945
Opened 5 years ago
Closed 5 years ago
The "about:logins" page wrongly shows that your are no longer logged into the FxA account after revealing or coping a password
Categories
(Firefox :: about:logins, defect, P1)
Tracking
()
VERIFIED
FIXED
Firefox 70
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | verified |
People
(Reporter: cmuntean, Assigned: jaws)
References
Details
(Whiteboard: [passwords:management] [skyline])
Attachments
(2 files)
page shows that you are logged out.gif
[Affected Versions]:
- Nightly 70.0a1
[Affected Platforms]
- All Windows
- All Mac
- All Linux
[Prerequisites]
- Be logged with a valid FxA account
- Have at least one saved login.
[Steps to reproduce]:
- Open the latest Nightly browser with the profile from prerequisites.
- Navigate to "about:logins" page.
- Click one of the saved logins.
- Click the "Show Password" or "Copy" button next to the password field.
- Observe the email and the avatar for the right corner of the "about:logins" page.
[Expected results]:
- The email and the avatar are correctly displayed.
[Actual results]:
- The email and the avatar are replaced by the "Sign in to Sync" button.
[Notes]:
- If the page is refreshed the email and the avatar are correctly redisplayed.
- Attached a screen recording with the issue.
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•5 years ago
|
Priority: -- → P1
|
|
Assignee | |
Comment 1•5 years ago
|
||
I'm going to investigate enabling no-fallthrough in eslint to prevent these from happening again.
|
||
Updated•5 years ago
|
Attachment #9083134 -
Attachment description: Bug 1570945 - Add missing break; statement in receiveMessage to not fall through to updating sync state. r?MattN → Bug 1570945 - Remove unnecessary default case in AboutLoginsParent.jsm. r?MattN
|
|
Assignee | |
Comment 2•5 years ago
|
||
This bug was indirectly fixed by bug 1549808. I'm going to land the patch here just to remove the unnecessary 'default' case in AboutLoginsParent.jsm.
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/157fd6afba69
Remove unnecessary default case in AboutLoginsParent.jsm. r=MattN
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
|
Reporter | |
Comment 5•5 years ago
|
||
I have verified this issue on the latest Nightly 70.0a1 build (2019-08-08) (64 bit) on Windows 10 x64, Windows 7 x64m Mac 10.14 and Ubuntu 18.04.
- The email and the avatar are correctly displayed after revealing or coping a password.
Status: RESOLVED → VERIFIED
|
||
Updated•5 years ago
|
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla70 → Firefox 70
You need to log in
before you can comment on or make changes to this bug.
Description
•