Update DevTools builds to use Babel 7.x
Categories
(DevTools :: General, task)
Tracking
(firefox70 fixed)
| Tracking | Status | |
|---|---|---|
| firefox70 | --- | fixed |
People
(Reporter: loganfsmyth, Assigned: loganfsmyth)
References
(Blocks 2 open bugs)
Details
Attachments
(4 files)
Our devtools/client/shared/build/build.js build script runs Babel 6.x, which at this point is getting pretty old.
On the Debugger we'd like to get this done because we use Flowtype, and there is some newer Flowtype syntax that is only supported on Babel 7 since it didn't exist in Babel 6.x.
Specifically, passing explicit template arguments to function calls is not supported (https://flow.org/en/docs/types/generics/#toc-supplying-type-arguments-to-callables). We are running into this because newer versions of the react-redux type definitions expect users to do:
export default connect<Props, OwnProps>(
// ...
so that the props and are explicitly declared.
Note: Ideally whoever does this should also update the Debugger Webpack bundle scripts to also run Babel 7.x.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D42571
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D42572
Pushed by lsmyth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/aaa8310bb77f Part 1: Rebuild worker bundles to pick up some missing logic. r=jlast https://hg.mozilla.org/integration/autoland/rev/417761314937 Part 2: Upgrade debugger source-file processing to use Babel 7. r=jlast https://hg.mozilla.org/integration/autoland/rev/63c179f03c3e Part 3: Upgrade MC Devtools build logic to use Babel 7.x for compilation. r=jlast
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/aaa8310bb77f
https://hg.mozilla.org/mozilla-central/rev/417761314937
https://hg.mozilla.org/mozilla-central/rev/63c179f03c3e
|
|
Assignee | |
Comment 6•5 years ago
|
||
Pushed by lsmyth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/17057707d774 Part 4: Roll back one set of accidentally-included changes. r=jlast
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
Description
•