Closed
Bug 1572214
Opened 5 years ago
Closed 5 years ago
Upgrade the react-redux Flowtype definitions to one that uses templatized call
Categories
(DevTools :: Debugger, task, P3)
DevTools
Debugger
Tracking
(firefox71 fixed)
RESOLVED
FIXED
Firefox 71
| Tracking | Status | |
|---|---|---|
| firefox71 | --- | fixed |
People
(Reporter: loganfsmyth, Assigned: loganfsmyth)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [debugger-reserve])
Attachments
(3 files)
Once https://bugzilla.mozilla.org/show_bug.cgi?id=1572209 is done, this task is mostly busywork to update and pass the props properly to connect, since the newer versions of the type definitions require you to explicitly pass the template params, e.g.
export default connect<Props, OwnProps>(
|
||
Updated•5 years ago
|
Priority: -- → P3
|
Assignee | |
Updated•5 years ago
|
Keywords: good-first-bug
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → loganfsmyth
Status: NEW → ASSIGNED
|
||
Updated•5 years ago
|
Whiteboard: [debugger-mvp] → [debugger-reserve]
|
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D48476
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D48477
Pushed by loganfsmyth@gmail.com: https://hg.mozilla.org/integration/autoland/rev/6146ebca595a Part 1: Add more Flow type annotations and tweak logic to match in a few places. r=jlast https://hg.mozilla.org/integration/autoland/rev/93fa4a718f19 Part 2: Override Prettier Flow config to allow templatized call syntax. r=jlast https://hg.mozilla.org/integration/autoland/rev/bee723fdb043 Part 3: Update debugger to use new react-redux flow-typed bindings for better typechecking. r=jlast
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6146ebca595a
https://hg.mozilla.org/mozilla-central/rev/93fa4a718f19
https://hg.mozilla.org/mozilla-central/rev/bee723fdb043
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
You need to log in
before you can comment on or make changes to this bug.
Description
•