accept/tentative/decline toolbarbutton default actions do not work after de-xbl in bug 1547233
Categories
(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)
Tracking
(Not tracked)
People
(Reporter: mkmelin, Assigned: mkmelin)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
mkmelin
:
review+
jorgk-bmo
:
approval-calendar-beta+
|
Details | Diff | Splinter Review |
Accept/tentative/decline toolbarbutton default actions do not work after de-xbl in bug 1547233.
For command= the handling is automatic, but these buttons use oncommand, and then we need to handle stopping the event propagation.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Comment 2•5 years ago
|
||
Comment 3•5 years ago
|
||
Assignee | ||
Comment 4•5 years ago
|
||
(In reply to Philipp Kewisch [:Fallen] [:📆] from comment #3)
I see also a few updates to the functions managing attendee status, is this
related to the XBL changes as well?
My initial thought was to pass in the event to the (existing) reply() function and stop propagation there. Worked, but it was rather confusing with the three parameters, and then looking closer I notice it's just passing on the one parameter. So to keep the functions about what they do and not have a function do three different tasks at once, I decided to split reply up so that each function would just do one thing.
The dropping of defaults was just to make code more explicit about which case it was doing. There weren't many callers not specifying a parameter anyway.
Would it be possible to add some tests
around that?
While tests for this functionality could be useful, I'm not aware we have anything that tests this, and the particular case I'm fixing would be very hard for an automated test to check (e.g. that something was sent, or not, and only once).
Assignee | ||
Comment 5•5 years ago
|
||
Eslint didn't like more the previous solution (more than two statements on a line), so I went back to just reply() instead.
Successful try: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=45ed859a400ea66cf0c4a2ffcddbedb8180a9da4
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/dd2b0261882e
adjust invitation related toolbarbuttons to make default actions work again. r=Fallen
Updated•5 years ago
|
Comment 7•5 years ago
|
||
TB 69 beta 3 / Cal 7.1:
https://hg.mozilla.org/releases/comm-beta/rev/c850972a72351538ece8d91ed11c2f810769df3f
Description
•