Closed Bug 1572652 Opened 5 years ago Closed 4 years ago

Make the CSSGridHighlighter compatible with Fission

Categories

(DevTools :: Inspector, task, P3)

Product:
DevTools
Component:
Inspector
Type:
task

Tracking

(Fission Milestone:MVP, firefox86 fixed)

Status:
RESOLVED FIXED
Milestone:
86 Branch
Project Flags:
Fission Milestone MVP
Tracking Flags:
Tracking Status
firefox86 --- fixed

People

(Reporter: pbro, Assigned: rcaliman)

References

(Blocks 4 open bugs)

Details

(Whiteboard: dt-fission-m2-reserve)

Attachments

(5 files)

Bug 1572652 - [devtools] Refactor methods to show/hide CSS Grid highlighters for grids and subgrids. r=ochameau
(deleted), text/x-phabricator-request
Details
Bug 1572652 - [devtools] Remove CSS Grid highlighter management logic. r=ochameau
(deleted), text/x-phabricator-request
Details
Bug 1572652 - [devtools] Destroy grid highlighters when nodes stop being grid containers. r=ochameau
(deleted), text/x-phabricator-request
Details
Bug 1572652 - [devtools] Consolidate telemetry logging for grid and flexbox highlighters. r=nchevobbe
(deleted), text/x-phabricator-request
Details
Bug 1572652 - [devtools] Replace GridInspector.onShowGridOutlineHighlight() with thunk in Layout panel and update tests. r=nchevobbe
(deleted), text/x-phabricator-request
Details
No description provided.
Priority: P2 → P3
Whiteboard: dt-fission → dt-fission-reserve
Assignee: nobody → gl
Status: NEW → ASSIGNED
Priority: P3 → P1

Tentatively moving all bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to the "?" triage milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732

Fission Milestone: --- → ?

Tracking for enabling Fission in Nightly (M6)

Fission Milestone: ? → M6
Priority: P1 → P2
Whiteboard: dt-fission-reserve → dt-fission-m2-mvp
Priority: P2 → P1
Whiteboard: dt-fission-m2-mvp → dt-fission-m2-reserve

Tentatively moving P1 Fission M6 bugs to M6a.

Fission Milestone: M6 → M6a
Assignee: gl → nobody
Status: ASSIGNED → NEW
Priority: P1 → P3

dt-fission-m2-reserve bugs do not need to block Fission Nightly (M6). For now, let's track them for Fission riding the trains to Beta (M7) so we revisit these bugs before we ship Fission.

Fission Milestone: M6a → M7

Bulk move of all dt-fission-m2-reserve bugs to Fission MVP milestone.

Fission Milestone: M7 → MVP
No longer blocks: 1582732
Assignee: nobody → rcaliman
Status: NEW → ASSIGNED
Attachment #9192854 - Attachment description: Bug 1572652 - [devtools] [WIP] CSS Grid Highlighter refactoring → Bug 1572652 - [devtools] Refactor methods to show/hide CSS Grid highlighters for grids and subgrids
Attachment #9192854 - Attachment description: Bug 1572652 - [devtools] Refactor methods to show/hide CSS Grid highlighters for grids and subgrids → Bug 1572652 - [devtools] Refactor methods to show/hide CSS Grid highlighters for grids and subgrids. r=ochameau
Attachment #9192917 - Attachment description: Bug 1572652 - [devtools] Consolidate telemetry logging for grid and flexbox highlighters. r=ochameau → Bug 1572652 - [devtools] Consolidate telemetry logging for grid and flexbox highlighters. r=nchevobbe
Blocks: 1683153
Pushed by rcaliman@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f7bfc79760cd [devtools] Remove CSS Grid highlighter management logic. r=ochameau https://hg.mozilla.org/integration/autoland/rev/74a72fa64eac [devtools] Refactor methods to show/hide CSS Grid highlighters for grids and subgrids. r=ochameau https://hg.mozilla.org/integration/autoland/rev/5cec22070b21 [devtools] Destroy grid highlighters when nodes stop being grid containers. r=ochameau https://hg.mozilla.org/integration/autoland/rev/6af2239a55fe [devtools] Consolidate telemetry logging for grid and flexbox highlighters. r=nchevobbe https://hg.mozilla.org/integration/autoland/rev/780e919162d5 [devtools] Replace GridInspector.onShowGridOutlineHighlight() with thunk in Layout panel and update tests. r=nchevobbe
Blocks: 1683287
Blocks: 1684595
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: