Closed Bug 1574869 Opened 5 years ago Closed 5 years ago

All the buttons and fields from the “Login Item” and “Create New Login” mode are not functional when the Mobile Promotion is displayed

Categories

(Firefox :: about:logins, defect, P1)

Product:
Firefox
Component:
about:logins
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 70
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox68 --- unaffected
firefox69 --- disabled
firefox70 --- verified

People

(Reporter: srosu, Assigned: mcrawford)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [passwords:management] [skyline])

Attachments

(3 files, 1 obsolete file)

CreateLogin_blocked.mp4
(deleted), video/mp4
Details
banner blocking button inertaction
(deleted), image/png
Details
Bug 1574869 - The Mobile Promotion should be part of the <login-item> r?MattN
(deleted), text/x-phabricator-request
Details
Attached video CreateLogin_blocked.mp4 (deleted) —

[Affected versions]:

  • Firefox latest Nightly 70.0a1 (2019-08-18) (64-bit)

[Affected Platforms]:

  • Mac 10.14
  • Windows 10 x64
  • Ubuntu 18.04 x64

[Prerequisites]:

  • The Firefox browser is opened.
  • The "about:logins" page is opened.
  • Have the Mobile Promotion displayed.

[Steps to reproduce]:

  1. Click on the “Create New Login” button.
  2. Click on any button or field.
  3. Observe the behavior.

[Expected result]:

  • The buttons and fields are functional.

[Actual result]:

  • The buttons and fields are not functional.

[Regression]

  • The issue is not reproducible with older Nightly 70.0a1 builds. Considering this, using mozregression tool I have found the issue that broke this in the latest Nightly build. Here are the results:
  • Pushlog: https://tinyurl.com/y2sdndaw
  • Last good revision: ab3823d11ade127a8c4daff1bba4ae992a456da4
  • First bad revision: 773f75efd74530e39c0fff817d54c23b75425faa

From this pushlog it seems that bug 1550165 introduced this behavior.

[Notes]:

  • The issue is also reproducible for the Login Item. The “Edit”, “Delete”, “Launch” and copy buttons doesn't work.
  • The “Edit” mode cannot be opened since the “Edit” button doesn't work.
  • The buttons and the fields correctly work after the Mobile Promotion banner is dismissed.
  • Attached a screen recording with the issue.
Assignee: nobody → mcrawford
Status: NEW → ASSIGNED
Priority: -- → P1
Attached image banner blocking button inertaction (deleted) —

can coroborate on

  • W10 Pro x_64 1908 b18362.295
  • FX 70.0a1 (2019-08-20) (64-bit) (e7e658ec1e98c3868b98195c2ee4b9fe3842172e)
Attachment #9086781 - Attachment is obsolete: true

https://hg.mozilla.org/mozilla-central/rev/c3d5f2f611fc

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70

I have verified this issue and is no longer reproducible on the latest Nightly 70.0a1 (2019-08-23)(64-bit) build on Windows 7 x64, Mac 10.14 and Ubuntu 16.04 x64.

  • All the buttons and the fields can be accessed while the "Mobile Promo" is displayed.
Status: RESOLVED → VERIFIED
status-firefox70: fixed → verified
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla70 → Firefox 70
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: