Footer advertising links to Lockwise mobile apps
Categories
(Firefox :: about:logins, enhancement, P1)
Tracking
()
People
(Reporter: jaws, Assigned: mcrawford)
References
Details
(Whiteboard: [passwords:management] [skyline] )
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
The login manager page should have a footer that has links to install the Lockwise mobile apps.
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Comment 1•5 years ago
|
||
How should we handle the localizing of the google play and app store icons? We had this as a todo for lockwise, I'll can ping m_and_m and see what the original plan was and report here.
Comment 2•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Reporter | ||
Updated•5 years ago
|
Reporter | ||
Comment 3•5 years ago
|
||
(In reply to Dave Justice [:JSON_voorhees / :meandave] from comment #1)
How should we handle the localizing of the google play and app store icons? We had this as a todo for lockwise, I'll can ping m_and_m and see what the original plan was and report here.
We should use graphics that don't include text. That will be the best approach. Let's exhaust that search before trying to figure out what to do otherwise.
Reporter | ||
Comment 4•5 years ago
|
||
Until we hear back from legal to clear us packaging these graphics, can you include all of the graphics in each locale in your patch, and then add some code to choose the right graphic based on the browser's locale? You can enumerate the array from Services.locale.requestedLocales[1] until you find a match of a graphic that we are shipping. If no match is found then you could use the "en-US" graphics.
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Comment 5•5 years ago
|
||
[Tracking Requested - why for this release]:
Updated•5 years ago
|
Comment 8•5 years ago
|
||
Backed out changeset fc5ca772497d (bug 1550165) for causing build bustages. CLOSED TREE
Backout revision https://hg.mozilla.org/integration/autoland/rev/91ae5f60b8c081767422e8bf9bb88d666ff204b3
Failed push https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=fc5ca772497d74b3201cdd8fa0a2c09a83f51d51
Failure log https://treeherder.mozilla.org/logviewer.html#?job_id=261634994&repo=autoland
Dave can you please take a look?
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/autoland/rev/9a0528095590
Footer advertising links to Lockwise mobile apps. r=fluent-reviewers,Pike,MattN
Comment 10•5 years ago
|
||
Backed out changeset 9a0528095590 (bug 1550165) for browser chrome failures in browser_all_files_referenced.js
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=261826567&repo=autoland&lineNumber=2025
Backout: https://hg.mozilla.org/integration/autoland/rev/195166db95ccaae18f182af7ef11e576b29d13e4
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 11•5 years ago
|
||
Pushed by dluca@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/773f75efd745
Footer advertising links to Lockwise mobile apps. r=fluent-reviewers,Pike,MattN
Comment 13•5 years ago
|
||
bugherder |
Comment 14•5 years ago
|
||
I have verified this issue on the latest Nightly 70.0a1 (2019-08-18) (64-bit) on Windows 10, MacOS 10.14 and Ubuntu 18.04.
- The Mobile Promotion is displayed on the bottom of "about:logins" page.
However, while verifying that the Mobile Promotion is displayed we have encountered the following issues:
- Mobile promotion is displayed even if you are not logged in. Logged bug 1574873.
- Mobile Promotion overlaps with the "Login Item" when resizing the browser. Logged bug 1574883.
Also, it seems that this feature introduced the following regressions:
- All the buttons and fields from the “Login Item” and “Create New Login” mode are no more functional when the Mobile Promotion is displayed. Logged bug 1574869.
- The "Lockwise" favicon is no longer displayed on the "Logins & Passwords" tab. Logged bug 1574876.
Comment 15•5 years ago
|
||
This bug caused the regression below which was not backed out, but fixed by bug 1555894. Does this make sense?
== Change summary for alert #22500 (as of Fri, 16 Aug 2019 15:20:10 GMT) ==
Regressions:
1% installer size osx-shippable opt nightly 79,847,226.33 -> 80,453,554.00
For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=22500
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Description
•