Closed Bug 1574954 Opened 5 years ago Closed 5 years ago

Fix overlapping issues with about:logins footer

Categories

(Firefox :: about:logins, defect, P2)

Product:
Firefox
Component:
about:logins
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 70
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- unaffected
firefox69 --- disabled
firefox70 --- verified
firefox71 --- verified

People

(Reporter: ehsan.akhgari, Assigned: ntim)

References

Details

(Whiteboard: [passwords:management] [skyline][test-isolation-backout])

Attachments

(2 files, 1 obsolete file)

Screenshot
(deleted), image/png
Details
Bug 1574954 - Fix overlapping issues with login-footer. r=jaws
(deleted), text/x-phabricator-request
Details
Attached image Screenshot (deleted) —

See the screenshot, look at how the two icons are overlaying each other.

Blocks: 1550165
Priority: -- → P2
Whiteboard: [passwords:management] [skyline]
Assignee: nobody → mcrawford
Status: NEW → ASSIGNED

Should this grow with the horizontal line if the window expands, and is there a minimum experience? Or does the horizontal line (the login-item header bottom border) stop growing at 700px (or whatever it is) and that should be the max for the app store icon box as well?

Flags: needinfo?(rgaddis)
Assignee: mcrawford → ntim.bugs
Summary: The app store icons overlay each other when the width of the window containing about:login isn't wide enough → The app store icons overlay each other when the width of the window containing about:logins isn't wide enough
Flags: needinfo?(rgaddis)
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/827537e16838 Fix overlapping issues with login-footer. r=jaws
Blocks: 1574883
Summary: The app store icons overlay each other when the width of the window containing about:logins isn't wide enough → Fix overlapping issues with about:logins footer
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/c44bd068d13f Fix overlapping issues with login-footer. r=jaws
Flags: needinfo?(ntim.bugs)
Whiteboard: [passwords:management] [skyline] → [passwords:management] [skyline][test-isolation-backout]

https://hg.mozilla.org/mozilla-central/rev/c44bd068d13f

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox70: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Attachment #9087869 - Attachment is obsolete: true
Whiteboard: [passwords:management] [skyline][test-isolation-backout] → [passwords:management] [skyline][test isolation backout]
Whiteboard: [passwords:management] [skyline][test isolation backout] → [passwords:management] [skyline][test-isolation-backout]

I have verified this issue on the Firefox Beta 70.0b11 (Build ID: 20190930132843) and on the latest Nightly 71.0a1 (Build ID: 20191001041624) build on Windows 10, MacOS 10.14 and Ubuntu 16.04 x64.

  • The Mobile Promotion from “about:logins” page doesn't overlap with the “Login Item” Mode when resizing the browser.
  • The buttons from the Mobile Promotion do not overlap when resizing the browser.
Status: RESOLVED → VERIFIED
status-firefox69: --- → disabled
status-firefox70: fixed → verified
status-firefox71: --- → verified
status-firefox-esr60: --- → unaffected
status-firefox-esr68: --- → unaffected
Component: Password Manager → about:logins
Product: Toolkit → Firefox
Target Milestone: mozilla70 → Firefox 70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: