Closed
Bug 1577783
Opened 5 years ago
Closed 5 years ago
In Browser Toolbox, clicking on an Element node target icon should navigate to the right node in the inspector
Categories
(DevTools :: Shared Components, task, P1)
DevTools
Shared Components
Tracking
(firefox71 fixed)
RESOLVED
FIXED
Firefox 71
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: nchevobbe, Assigned: nchevobbe)
References
(Blocks 1 open bug)
Details
(Whiteboard: dt-fission-m1)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
This means we need to fix how we handle things now.
Because Reps only works on grips, it means that at some point in the action we need to retrieve the nodeFront that matches the grip.
As we move Fission forward, this will be tricky to do because we need to get the right (contextual) walker to do such thing, which isn't easy.
An easier way would be for Reps to simply handle fronts.
Since Reps is used in may places (inspector, debugger, console, …) this might be a significant task (but also one that we want to do to have a cleaner codebase).
Setting as P3 for now as we may want to do this as part of M2. We'll move it to M1 if we have enough time to do it.
Updated•5 years ago
|
Whiteboard: dt-fission → dt-fission-reserve
Assignee | ||
Updated•5 years ago
|
Priority: P3 → P2
Updated•5 years ago
|
Whiteboard: dt-fission-reserve → dt-fission
Assignee | ||
Comment 1•5 years ago
|
||
Depends on D48809
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Updated•5 years ago
|
Priority: P2 → P1
Updated•5 years ago
|
Attachment #9100112 -
Attachment description: Bug 1577783 - [WIP] Use toolbox's getNodeFrontFromNodeGrip function in WebConsole's openNodeInInspector. r=pbro,rcaliman. → Bug 1577783 - Use inspectorFront's getNodeFrontFromNodeGrip function in WebConsole's openNodeInInspector. r=pbro.
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3eec673dbb60
Use inspectorFront's getNodeFrontFromNodeGrip function in WebConsole's openNodeInInspector. r=pbro,rcaliman.
Comment 3•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox71:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Updated•5 years ago
|
Whiteboard: dt-fission → dt-fission dt-fission-m1
Updated•3 years ago
|
Whiteboard: dt-fission dt-fission-m1 → dt-fission-m1
You need to log in
before you can comment on or make changes to this bug.
Description
•