Closed
Bug 1580719
Opened 5 years ago
Closed 5 years ago
remove grid usage from comm/mail/components/compose/content/dialogs/edImage.inc.xul
Categories
(Thunderbird :: Message Compose Window, task)
Thunderbird
Message Compose Window
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 71.0
People
(Reporter: khushil324, Assigned: khushil324)
References
Details
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
khushil324
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → khushil324
Blocks: tb-burn-xul-grids
Comment 2•5 years ago
|
||
Comment on attachment 9092562 [details] [diff] [review] Bug-1580719_remove-grid-edImage-inc-xul.patch Review of attachment 9092562 [details] [diff] [review]: ----------------------------------------------------------------- ::: mail/components/compose/content/dialogs/edImage.inc.xul @@ +43,5 @@ > + control="titleInput" > + accesskey="&title.accessKey;" > + value="&title.label;" > + tooltiptext="&title.tooltip;" > + for="titleInput"/> this is a xul:label, it does't have for, so remove that @@ +57,5 @@ > + </hbox> > + </vbox> > + <vbox> > + <textbox flex="1" > + id="titleInput" move id first here, and in the other case @@ +133,5 @@ > + <vbox flex="1"> > + <menulist id="widthUnitsMenulist" > + oncommand="doDimensionEnabling();" /> > + <menulist id="heightUnitsMenulist" > + oncommand="doDimensionEnabling();" /> alignment off by a space or two
Attachment #9092562 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Comment 3•5 years ago
|
||
Attachment #9092562 -
Attachment is obsolete: true
Attachment #9092629 -
Flags: review+
Assignee | ||
Updated•5 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•5 years ago
|
Status: NEW → ASSIGNED
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/3fbaa02a4fce
remove grid usage from edImage.inc.xul. r=mkmelin
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 71.0
You need to log in
before you can comment on or make changes to this bug.
Description
•