Closed
Bug 1581152
Opened 5 years ago
Closed 5 years ago
TypeError: this.buttons.proceedDefaultAction is not a function
Categories
(Thunderbird :: Instant Messaging, defect)
Thunderbird
Instant Messaging
Tracking
(thunderbird_esr6869+ fixed, thunderbird70 fixed, thunderbird71 fixed)
RESOLVED
FIXED
Thunderbird 71.0
People
(Reporter: clokep, Assigned: khushil324)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
clokep
:
review+
jorgk-bmo
:
approval-comm-beta+
jorgk-bmo
:
approval-comm-esr68+
|
Details | Diff | Splinter Review |
Steps to reproduce:
- Open the chat account preferences
- Double click on an existing account
- See error:
chrome://chat/content/chat-account-richlistitem.js, line 47: TypeError: this.buttons.proceedDefaultAction is not a function
This should connect/disconnect the account. I suspect this is from de-XBL?
Reporter | ||
Comment 1•5 years ago
|
||
Likely a regression from bug 1531312.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → khushil324
Assignee | ||
Comment 2•5 years ago
|
||
Attachment #9092707 -
Flags: review?(clokep)
Assignee | ||
Updated•5 years ago
|
Status: NEW → ASSIGNED
Reporter | ||
Comment 3•5 years ago
|
||
Comment on attachment 9092707 [details] [diff] [review]
Bug-1581152_proceedDefaultAction-in-chat-corrected.patch
Works fine. Do you know if this needs uplift to 68?
Attachment #9092707 -
Flags: review?(clokep) → review+
Assignee | ||
Comment 4•5 years ago
|
||
Reporter | ||
Comment 5•5 years ago
|
||
Comment on attachment 9092707 [details] [diff] [review]
Bug-1581152_proceedDefaultAction-in-chat-corrected.patch
[Approval Request Comment]
Regression caused by (bug #): bug 1531312
User impact if declined: Double clicking to connect/disconnect accounts will not work
Testing completed (on c-c, etc.): Tested locally
Risk to taking this patch (and alternatives if risky): The risk is that double clicking to connect/disconnect accounts still won't work
Attachment #9092707 -
Flags: approval-comm-esr68?
Attachment #9092707 -
Flags: approval-comm-beta?
Assignee | ||
Updated•5 years ago
|
Keywords: checkin-needed
Updated•5 years ago
|
Attachment #9092707 -
Flags: approval-comm-esr68?
Attachment #9092707 -
Flags: approval-comm-esr68+
Attachment #9092707 -
Flags: approval-comm-beta?
Attachment #9092707 -
Flags: approval-comm-beta+
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/1ad46bfea4c7
fix invocation of proceedDefaultAction() in chat-account-richlistitem.js. r=clokep
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 71.0
Comment 7•5 years ago
|
||
TB 70 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/01771e7596ed29af3c7030c2656f312f92303c8c
status-thunderbird70:
--- → fixed
status-thunderbird71:
--- → fixed
Comment 8•5 years ago
|
||
TB 68.1.1 ESR:
https://hg.mozilla.org/releases/comm-esr68/rev/34f40a569c90ca411648f9440d3a82620c8588c8
status-thunderbird_esr68:
--- → fixed
tracking-thunderbird_esr68:
--- → 69+
Updated•4 years ago
|
Keywords: regression
You need to log in
before you can comment on or make changes to this bug.
Description
•