Comment on attachment 9093038 [details] [diff] [review] Bug-1581534_remove-grid-EdTableProps.patch Review of attachment 9093038 [details] [diff] [review]: ----------------------------------------------------------------- This dialog is such a mess... (to start with) ::: mail/components/compose/content/dialogs/EdTableProps.xul @@ +51,5 @@ > + <html:div> > + <textbox class="narrow" id="TableRowsInput" oninput="forceInteger(this.id);"/> > + </html:div> > + <html:div> > + <spring class="bigspacer"/> we shouldn't need to use <spring>.

Comment on attachment 9093270 [details] [diff] [review] Bug-1581534_remove-grid-EdTableProps.patch Review of attachment 9093270 [details] [diff] [review]: ----------------------------------------------------------------- The 3 "pixels" dropdowns are misaligned. But, I think this whole dialog is extremely confusing. What you really have is Selection ---- Size table, Content Alignment table. ... and a bunch of things unrelated in any way. You don't really have a 6 column grid. It's 2 or 3 columns. You may want to have several sections.

Comment on attachment 9094172 [details] [diff] [review] Bug-1581534_remove-grid-EdTableProps.patch Review of attachment 9094172 [details] [diff] [review]: ----------------------------------------------------------------- The size dropdown is still not correctly aligned. Will attach a screenshot. BTW, what about the Cells tab?

Comment on attachment 9094385 [details] [diff] [review] Bug-1581534_remove-grid-EdTableProps.patch Review of attachment 9094385 [details] [diff] [review]: ----------------------------------------------------------------- In the cells tab, the dropdowns for size are still misaligned Size in the table tab is now ok