Closed
Bug 1581558
Opened 5 years ago
Closed 5 years ago
remove grid usage from comm/mail/components/compose/content/dialogs/EdInsertTable.xul
Categories
(Thunderbird :: Message Compose Window, task)
Thunderbird
Message Compose Window
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 71.0
People
(Reporter: khushil324, Assigned: khushil324)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•5 years ago
|
Assignee: nobody → khushil324
Blocks: tb-burn-xul-grids
Assignee | ||
Comment 1•5 years ago
|
||
Attachment #9093050 -
Flags: review?(mkmelin+mozilla)
Assignee | ||
Updated•5 years ago
|
Status: NEW → ASSIGNED
Comment 2•5 years ago
|
||
Comment on attachment 9093050 [details] [diff] [review]
Bug-1581558_remove-grid-EdInsertTable.patch
Review of attachment 9093050 [details] [diff] [review]:
-----------------------------------------------------------------
Size looks like it should be a table.
Could you change the textboxes to <html:input type="number", class="size3"> while you're here
Attachment #9093050 -
Flags: review?(mkmelin+mozilla)
Assignee | ||
Comment 3•5 years ago
|
||
class="size3" is not defined in the EditorDialog.css. They have previously used class="narrow" to set the width for textbox so I have used that for html:input also.
Attachment #9093050 -
Attachment is obsolete: true
Attachment #9093355 -
Flags: review?(mkmelin+mozilla)
Assignee | ||
Comment 4•5 years ago
|
||
Attachment #9093355 -
Attachment is obsolete: true
Attachment #9093355 -
Flags: review?(mkmelin+mozilla)
Attachment #9093370 -
Flags: review?(mkmelin+mozilla)
Comment 5•5 years ago
|
||
Comment on attachment 9093370 [details] [diff] [review]
Bug-1581558_remove-grid-EdInsertTable.patch
Review of attachment 9093370 [details] [diff] [review]:
-----------------------------------------------------------------
LGTM, r=mkmelin
Attachment #9093370 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/f98a3da9570a
remove grid usage from EdInsertTable.xul. r=mkmelin
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 71.0
You need to log in
before you can comment on or make changes to this bug.
Description
•