Closed
Bug 1581725
Opened 5 years ago
Closed 4 years ago
remove grid usage from comm/mail/components/preferences/connection.xul
Categories
(Thunderbird :: Preferences, task)
Thunderbird
Preferences
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 77.0
People
(Reporter: khushil324, Assigned: ntim)
References
Details
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Updated•5 years ago
|
Blocks: tb-burn-xul-grids
Depends on: 1581670
Reporter | ||
Updated•5 years ago
|
Assignee: nobody → khushil324
Reporter | ||
Comment 2•5 years ago
|
||
Apply after patch from Bug 1583725.
Attachment #9095163 -
Flags: review?(mkmelin+mozilla)
Reporter | ||
Updated•5 years ago
|
Status: NEW → ASSIGNED
Comment 3•5 years ago
|
||
Reporter | ||
Comment 4•5 years ago
|
||
Yeah, now I am waiting for the review from Magnus.
Comment 5•5 years ago
|
||
This is the last de-grid bug, what's the hold up?
Comment 6•5 years ago
|
||
Intertwined with Fluent, which we want to sort out first.
Comment 7•5 years ago
|
||
See also bug 1630084 which we may want to port at the same time.
Comment 8•4 years ago
|
||
Comment on attachment 9095163 [details] [diff] [review]
Bug-1581725_remove-grid_connection.patch
Review of attachment 9095163 [details] [diff] [review]:
-----------------------------------------------------------------
Can you update this and bug 1583725 so it applies to trunk. (And sync up with bug 1630084)
Attachment #9095163 -
Flags: review?(mkmelin+mozilla)
Assignee | ||
Comment 9•4 years ago
|
||
Comment 10•4 years ago
|
||
I added some code from m-c to resize the dialog when in DoH the Custom menuitem is selected.
Attachment #9142767 -
Flags: review?(mkmelin+mozilla)
Comment 11•4 years ago
|
||
Comment on attachment 9142767 [details] [diff] [review]
1581725-de-grid-connection.diff
Review of attachment 9142767 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good - Thanks Tim, thanks Richard! r=mkmelin
Attachment #9142767 -
Flags: review?(mkmelin+mozilla) → review+
Updated•4 years ago
|
Keywords: checkin-needed-tb
Target Milestone: --- → Thunderbird 77.0
Updated•4 years ago
|
Attachment #9095163 -
Attachment is obsolete: true
Updated•4 years ago
|
Attachment #9142732 -
Attachment is obsolete: true
Reporter | ||
Updated•4 years ago
|
Assignee: khushil324 → ntim.bugs
Comment 12•4 years ago
|
||
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/8f4003786ce8
Remove grid usage from comm/mail/components/preferences/connection.xhtml. r=mkmelin
You need to log in
before you can comment on or make changes to this bug.
Description
•