Remove XUL grid from toolkit/components/prompts/content/commonDialog.xul
Categories
(Toolkit Graveyard :: Notifications and Alerts, task)
Tracking
(firefox72 disabled, firefox73 fixed)
People
(Reporter: ntim, Assigned: ntim)
References
Details
Attachments
(4 files)
|
(deleted),
image/png
|
Details | |
|
(deleted),
text/x-phabricator-request
|
Details | |
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
Screenshot
|
Assignee | |
Comment 1•5 years ago
|
||
Visit https://lgg.epfl.ch/teaching/DGP2019/Slides/html/01_Introduction.html to trigger the dialog
|
|
Assignee | |
Comment 2•5 years ago
|
||
A subgrid-based approach seems pretty promising for this one, since we want to keep the row-based markup.
|
|
Assignee | |
Comment 3•5 years ago
|
||
This makes use of CSS subgrid in order to preserve the row-based markup that is needed by JS to hide certain rows.
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 4•5 years ago
|
||
Visiting the dialog from comment 1 shouldn't have any visual difference before and after this change (I've tested on macOS, but it would be nice if someone could test on Linux/Windows).
|
|
Assignee | |
Comment 5•5 years ago
|
||
Mats, is it ok to start using subgrid in the Firefox UI?
|
||
Comment 6•5 years ago
|
||
Sure, I don't see a problem with that. I'd like to note though that it should be quite rare to need that kind of complexity. In this case for example, it seems you could use display:contents instead, which results in a much simpler frame tree.
|
|
||
Comment 7•5 years ago
|
||
This gets rid of #filler too.
|
|
Assignee | |
Comment 8•5 years ago
|
||
Thanks for taking a look into this! Nice trick with display: contents and thanks for catching #filler too :)
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/70b2e0edb9a1 Replace commonDialog.xul XUL grid with CSS grid. r=dao
|
||
Comment 10•5 years ago
|
||
| bugherder | ||
|
||
Comment 11•5 years ago
|
||
Verified as fixed on Windows 10, macOS 10.15 and Ubuntu 18.04 using Firefox 72.0a1 (20191129094247).
|
||
Comment 12•5 years ago
|
||
Backed out for 72.0-build4:
https://hg.mozilla.org/releases/mozilla-release/rev/d2bd57dbd560
|
||
Updated•1 year ago
|
Description
•