Master password dialog should be wider
Categories
(Toolkit Graveyard :: Notifications and Alerts, defect)
Tracking
(firefox-esr68 unaffected, firefox71 unaffected, firefox72 disabled, firefox73 verified)
| Tracking | Status | |
|---|---|---|
| firefox-esr68 | --- | unaffected |
| firefox71 | --- | unaffected |
| firefox72 | --- | disabled |
| firefox73 | --- | verified |
People
(Reporter: dekeltal, Assigned: ntim)
References
(Regression)
Details
(Keywords: regression)
Attachments
(4 files)
2019-11-28 11_23_49-Password Required.png
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0
Steps to reproduce:
Navigated to a page that requires credentials
Actual results:
Since FF is configured to use a master password, I got the "Password Required" popup. It seems there's a regression, where the controls in the popup are misaligned (see attachment). Not sure what changed exactly, but the buttons at the bottom and the password text box seem off.
|
||
Comment 1•5 years ago
|
||
| regression-window | ||
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0
20191128094109
On my system, "password." is now wrapped on a separate line.
|
|
||
Updated•5 years ago
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 2•5 years ago
|
||
Do you have a screenshot of how it looked like previously ?
|
|
Assignee | |
Comment 3•5 years ago
|
||
Dão, I think this used to "work" thanks to the #filler element which was forcing width: 29em; (which would explain why the text now wraps as comment 1 shows) and with the negative margins set on it . It was making sure the center-aligned dialog buttons (which were outside the grid) looked aligned with the text. I suspect this didn't work well with different locales though.
I can't really test this since macOS isn't affected by this (and aligns its buttons to the right as well), but what do you think of re-introducing a per-platform min-width, something like:
:root {
min-width: calc(29em - /* value that makes the buttons aligned */);
}
|
|
Assignee | |
Comment 5•5 years ago
|
||
Thanks! It looks like this wasn't aligned to the input before, so what I said in Comment 3 about the negative margins was wrong. Looks like we do need a min-width however to make it look like it was before.
|
|
Assignee | |
Comment 6•5 years ago
|
||
|
||
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/e14237c29b51 Re-introduce a minimum width to commonDialog.xul. r=dao
|
||
Comment 8•5 years ago
|
||
| bugherder | ||
|
||
Updated•5 years ago
|
|
||
Comment 9•5 years ago
|
||
Backed out for 72.0-build4:
https://hg.mozilla.org/releases/mozilla-release/rev/d2bd57dbd560
|
||
Updated•5 years ago
|
|
||
Comment 10•5 years ago
|
||
I have reproduced this issue using Firefox 72.0a1 (2019.11.28) on Win 8.1 x64.
I can confirm this issue is fixed, I verified using Firefox 73.0b4 on Win 8.1 x64.
|
||
Updated•1 year ago
|
Description
•