Closed Bug 1585193 Opened 5 years ago Closed 5 years ago

toolkit/components/search/tests/xpcshell/test_json_cache_good.js and toolkit/components/search/tests/xpcshell/test_json_cache_broken.js fail when run as part of the Thunderbird Xpcshell tests

Categories

(Firefox :: Search, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 71
Tracking Status
firefox71 --- fixed

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1582086 +++

Needs to be switched off after bug 1584491 again.

Attached patch 1585193.patch (deleted) — Splinter Review

Bug 1585193 - disable test_json_cache_{good|broken}.js for Thunderbird. r=standard8

Carrying forward Mark's review from Phab.

Assignee: nobody → jorgk
Status: NEW → ASSIGNED
Attachment #9097632 - Flags: review+

Dear sheriffs, this needs "old-style" manual landing due to bug 1576146. Same patch as in Phab with the correct commit message incl. r=standard8.

Keywords: checkin-needed

Pushed by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3d1e63128737
disable test_json_cache_{good|broken}.js for Thunderbird. r=standard8 on a CLOSED TREE

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71

Something went wrong when pushing this patch. It got landed with the sheriff as the author. Did you not import the patch using
hg qimport bz:1585193
or
hg qimport https://bugzilla.mozilla.org/attachment.cgi?id=9097632 -n some-name.patch
?

Jorg: i think it got imported with hg import https://bug1585193.bmoattachments.org/attachment.cgi?id=9097632

Do you want me to backout and reland?

Flags: needinfo?(jorgk)

Please don't :-) - Those two lines are not really important and there is no great authorship attached to them. Just something to keep in mind for next time. It worked perfectly here in another bug: https://hg.mozilla.org/mozilla-central/rev/5460d334b4605b4c17078bfabb65c77f0233d9ea
But for that bug, I talked to the sheriff on duty and suggested to use hg qimport.

Flags: needinfo?(jorgk)

Got it, thank you.

Has Regression Range: --- → yes
Keywords: regression
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: