toolkit/components/search/tests/xpcshell/test_json_cache_good.js and toolkit/components/search/tests/xpcshell/test_json_cache_broken.js fail when run as part of the Thunderbird Xpcshell tests
Categories
(Firefox :: Search, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox71 | --- | fixed |
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
+++ This bug was initially created as a clone of Bug #1582086 +++
Needs to be switched off after bug 1584491 again.
Assignee | ||
Comment 1•5 years ago
|
||
Assignee | ||
Comment 2•5 years ago
|
||
Bug 1585193 - disable test_json_cache_{good|broken}.js for Thunderbird. r=standard8
Carrying forward Mark's review from Phab.
Assignee | ||
Comment 3•5 years ago
|
||
Dear sheriffs, this needs "old-style" manual landing due to bug 1576146. Same patch as in Phab with the correct commit message incl. r=standard8.
Pushed by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3d1e63128737
disable test_json_cache_{good|broken}.js for Thunderbird. r=standard8 on a CLOSED TREE
Comment 5•5 years ago
|
||
bugherder |
Assignee | ||
Comment 6•5 years ago
|
||
Something went wrong when pushing this patch. It got landed with the sheriff as the author. Did you not import the patch using
hg qimport bz:1585193
or
hg qimport https://bugzilla.mozilla.org/attachment.cgi?id=9097632 -n some-name.patch
?
Comment 7•5 years ago
|
||
Jorg: i think it got imported with hg import https://bug1585193.bmoattachments.org/attachment.cgi?id=9097632
Do you want me to backout and reland?
Assignee | ||
Comment 8•5 years ago
|
||
Please don't :-) - Those two lines are not really important and there is no great authorship attached to them. Just something to keep in mind for next time. It worked perfectly here in another bug: https://hg.mozilla.org/mozilla-central/rev/5460d334b4605b4c17078bfabb65c77f0233d9ea
But for that bug, I talked to the sheriff on duty and suggested to use hg qimport
.
Comment 9•5 years ago
|
||
Got it, thank you.
Updated•3 years ago
|
Updated•3 years ago
|
Description
•