remove grid usage from comm/calendar/resources/content/calendarCreation.xul
Categories
(Calendar :: Calendar Frontend, task)
Tracking
(Not tracked)
People
(Reporter: khushil324, Assigned: khushil324)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
mkmelin
:
review+
|
Details | Diff | Splinter Review |
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
Apply after patch from Bug 1568660.
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 2•5 years ago
|
||
Comment on attachment 9099045 [details] [diff] [review] Bug-1586371_remove-grid-calendarCreation-1.patch Review of attachment 9099045 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. To fix in the heading: Create a new calendar Locate your calendar <-- This line is indented relative to the first line, but shouldn't be indented, they should both be right-aligned.
|
|
||
Comment 3•5 years ago
|
||
After I chatted briefly with Khushil about this, I took a closer look. The indentation is from the default <wizard> styles, which appear to have changed. The indented line is part of the wizard's shadow-root. So something like the following in calendar-creation-wizard.css should work:
wizard::shadow .wizard-header-description {
margin-inline-start: 23px !important;
}
But it did not work for me for some reason. So in the interest of not going too far out of our way to override default styling, I'd say let's just embrace the indented style and maybe revisit in a follow-up effort later if we're so inclined. With the shift from XUL to HTML this will likely all get reshuffled to some extent anyway.
|
|
||
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
||
Comment 4•5 years ago
|
||
|
|
||
Updated•5 years ago
|
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/69a2aa5bd636
remove grid usage from calendarCreation.xul. r=pmorris DONTBUILD
|
||
Comment 6•5 years ago
|
||
This broke calendar/test/browser/browser_localICS.js, and (indirectly, I think) calendar/test/browser/browser_todayPane.js. It wasn't picked up by the Try run because the Try run didn't actually do the calendar UI tests. Backed out:
https://hg.mozilla.org/comm-central/rev/0393c0d6beda736f7cc0cf340af099d8502bbc99
|
|
Assignee | |
Comment 7•5 years ago
|
||
comm/calendar/test/browser/browser_todayPane.js
comm/calendar/test/browser/browser_localICS.js
This two mochitests failed previously. Magnus, Can you confirm that these tests pass now?
|
||
Comment 8•5 years ago
|
||
./mach test comm/calendar/test/browser/browser_localICS.js
./mach test comm/calendar/test/browser/browser_todayPane.js
Both succeed with the patch.
|
|
||
Updated•5 years ago
|
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/fd44a1cc026d
remove grid usage from calendarCreation.xul. r=pmorris,mkmelin
|
|
||
Comment 10•5 years ago
|
||
The overlay directives for the two overlay files that were deleted/inlined in this bug weren't removed along with the files. I'm removing them over here: https://bugzilla.mozilla.org/show_bug.cgi?id=1508119#c31
Description
•