Closed
Bug 1586936
Opened 5 years ago
Closed 5 years ago
Thunderbird css changes for panel de-xbl (bug 1397876)
Categories
(Thunderbird :: General, task)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 71.0
People
(Reporter: mkmelin, Assigned: Paenglab)
Details
Attachments
(1 file)
|
(deleted),
patch
|
aleca
:
review+
|
Details | Diff | Splinter Review |
There are a number of CSS changes that will be needed for <panel> as a Custom Element (using Shadow Parts instead of XBL traversal in CSS). See examples at:
https://phabricator.services.mozilla.com/D35040 of bug 1397876.
Richard, any interest in this? If not, maybe Alex can take a look?
|
||
Comment 1•5 years ago
|
||
I'm prioritizing bug 440377 and bug 1573678, which combined will take most likely 2 or 3 weeks.
If Richard is busy, I might be able to squeeze this in after I'm back from Italy (Oct. 26)
|
Assignee | |
Comment 2•5 years ago
|
||
I also fixed customizeMode.inc.css albeit we don't use it now.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9099492 -
Flags: review?(mkmelin+mozilla)
|
||
Comment 3•5 years ago
|
||
Comment on attachment 9099492 [details] [diff] [review]
1586936-panel-to-CE.patch
I guess this needs to land before Magnus returns.
Attachment #9099492 -
Flags: review?(alessandro)
|
|
||
Comment 4•5 years ago
|
||
Comment on attachment 9099492 [details] [diff] [review]
1586936-panel-to-CE.patch
Review of attachment 9099492 [details] [diff] [review]:
-----------------------------------------------------------------
This looks good to me.
Thanks for taking care of this, Richard.
Attachment #9099492 -
Flags: review?(alessandro) → review+
|
|
Assignee | |
Updated•5 years ago
|
Attachment #9099492 -
Flags: review?(mkmelin+mozilla)
|
|
Assignee | |
Updated•5 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/b29c52c255ed
Port bug 1397876: Replace panel and arrowpanel bindings with a custom element. r=aleca
|
|
||
Updated•5 years ago
|
Target Milestone: --- → Thunderbird 71.0
You need to log in
before you can comment on or make changes to this bug.
Description
•