Closed Bug 1590982 Opened 5 years ago Closed 5 years ago

Show unsupported browsers' icon

Categories

(DevTools :: Inspector: Compatibility, enhancement, P3)

enhancement

Tracking

(firefox72 fixed)

VERIFIED FIXED
Firefox 72
Tracking Status
firefox72 --- fixed

People

(Reporter: daisuke, Assigned: daisuke)

References

(Blocks 1 open bug)

Details

Attachments

(6 files)

In bug 1589550, we show properties that are deprecated, experimental or unsupported though, the unsupported browser are not displayed.
In this bug, we additionally show the unsupported browsers as icon.

Priority: -- → P3
Attached video browser-icon-prototype.mp4 (deleted) —

Hi Victoria!
I made a prototype showing the unsupported browsers' icon.
I'd like to hear your opinion about especially followings:

Thanks!

Flags: needinfo?(victoria)

Hi Daisuke!

Wow, this prototype looks great! And the mobile icon is an awesome idea. It's much better than the 'm' :).

Re: the tooltip, I need to think about this part some more. (There's a section in the doc about this that seems a bit incomplete now that I'm looking at it :).)

Thank you very much for your feedback, Victoria!
Okay, I will proceed using the icon. (Patrick gave me the idea which uses the mobile icon :))
And, about tooltips, when you come up with something, please let me know!

Here are some ideas for the tooltip:

If ESR, current, and prerelease all have the problem:

Firefox 70 (current)


If it's fixed in prerelease, but missing until then:

Firefox 70 (current), support added in 71 beta

+Plus partial support indicator, like an asterisk to follow caniuse's pattern


If it's missing in prerelease, but supported until then:

Removed in Firefox 71 beta, supported in 70 release

+Plus partial support indicator


If it's fixed in current, but missing in ESR:

...do we show an error in this case? It would need a special indicator to communicate "pretty solid support."

CC: Martin :)

Flags: needinfo?(victoria) → needinfo?(mbalfanz)

IE would be a special case that would just say "Internet Explorer 11", etc

We could try a .5 opacity icon for partial support.

One tiny thing I noticed in the demo is that the bottom of the Firefox icons is cut off a bit :)

The wording sounds generally good to me. The one example I'm not so sure about is this:

If it's missing in prerelease, but supported until then:

Removed in Firefox 71 beta, supported in 70 release

I'm not sure if it's valuable to call out "supported in 70 release". In a way the CTA is to stop using whatever gets removed :)

Flags: needinfo?(mbalfanz)

Depends on D52971

(In reply to Martin Balfanz [:mbalfanz] from comment #7)

The wording sounds generally good to me. The one example I'm not so sure about is this:

If it's missing in prerelease, but supported until then:

Removed in Firefox 71 beta, supported in 70 release

I'm not sure if it's valuable to call out "supported in 70 release". In a way the CTA is to stop using whatever gets removed :)

I see what you mean. I see this example as such a tricky situation, that we might as well give the full info for clarity. (E.g. so people know things will start breaking soon, and it's not something that's just always been broken.) I'd hope the warning icon with "(deprecated)" is enough encouragement to fix the problem.

Thank you very much, Victoria, Martin!
Let me implement the tooltip in another bug since we need more information besides unsupported browsers information to implement this.

Attachment #9108634 - Attachment description: Bug 1590982: Iconize unsupporetd browsers. r?rcaliman,ladybenko → Bug 1590982: Iconize unsupported browsers. r?rcaliman,ladybenko
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c52756026ed0 Introduce UnsupportedBrowserList component. r=rcaliman,ladybenko https://hg.mozilla.org/integration/autoland/rev/befe2819a367 Introduce UnsupportedBrowserItem component. r=rcaliman,ladybenko https://hg.mozilla.org/integration/autoland/rev/64eb33d0156e Iconize unsupported browsers. r=rcaliman,ladybenko,Gijs https://hg.mozilla.org/integration/autoland/rev/db61ed78dc57 Add a jest for UnsupportedBrowserList component. r=ladybenko https://hg.mozilla.org/integration/autoland/rev/d35690bfcfb4 Add a jest for UnsupportedBrowserItem component. r=ladybenko
Assignee: nobody → daisuke

Marking as verified as part of the feature testing on 78(nightly) builds.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: