Follow movements of search engines in M-C
Categories
(Thunderbird :: Search, task)
Tracking
(Not tracked)
People
(Reporter: jorgk-bmo, Assigned: jorgk-bmo)
References
Details
Attachments
(3 files)
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review | |
|
(deleted),
patch
|
Details | Diff | Splinter Review |
M-C are reworking their search engine implementation. Let's not open a bug for every little thing that needs to be tweaked.
I'll make a start with porting bug 1592014:
https://hg.mozilla.org/mozilla-central/rev/1e8a2884d6bfda4eddd63150583e189947369fed
|
Assignee | |
Comment 1•5 years ago
|
||
This should do it:
Basically copied engines.json from M-C again and repeated the steps from bug 1583383 comment #14 without removing the telemetry IDs:
- removed eBay
- removed extraParams (Yandex, DDG, Bing)
- removed pc MOZI from Bing
- removed tags and client with firefox
- simplified Google appliesTo as suggested
- removed "tn": "monline_7_dg" from Baidu since it wasn't in the WE
- "tag": "mozillajapan-fx-22" and "tag": "mozilla-20" from Amazon, note sourceid=Mozilla-search is in the WEs
Checked JSON at https://jsonformatter.curiousconcept.com/
|
|
Assignee | |
Comment 3•5 years ago
|
||
sed -i -e '/engineName/d' engines.json.
Checked JSON at https://jsonformatter.curiousconcept.com/
|
||
Updated•5 years ago
|
|
|
Assignee | |
Comment 5•5 years ago
|
||
|
|
Assignee | |
Comment 7•5 years ago
|
||
Looks like bug 1600715 will need porting if tests blow up.
|
||
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 9•5 years ago
|
||
A bunch of tests from toolkit/components/search/tests have blown up again.
Last good: 5e69563343eb5bb7b8dfaaacc1e634e57d
First bad: 4f2f9bda72ac1c91576d2ca18d8323fe41
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5e69563343eb5bb7b8dfaaacc1e634e57d&tochange=4f2f9bda72ac1c91576d2ca18d8323fe41
Sadly there were three merges in this range, but anyway, easy to spot the issue: Bug 1590860, bug 1615309 and/or bug 1613348.
As a bustage fix you could likely get away with setting this pref:
https://hg.mozilla.org/mozilla-central/rev/7c6bdadeea29fab3700320515798d84ba3414f4f#l1.12
| Comment hidden (Intermittent Failures Robot) |
| Comment hidden (Intermittent Failures Robot) |
|
|
Assignee | |
Comment 12•5 years ago
|
||
Any plans to address this?
|
|
||
Comment 13•5 years ago
|
||
This has been dealt with in bug 1619173.
|
|
Assignee | |
Comment 14•5 years ago
|
||
If you say so. I'm surprised that none of bug 1590860, bug 1615309 and/or bug 1613348 needs further porting. And I put a bazillion incorrect stars onto the tree. I should stop doing so. Sorry.
Let's call this done then. Last landed patch in comment #8 in early Dec. 2019, so that makes it TB 73.
|
|
Assignee | |
Comment 15•5 years ago
|
||
Hmm, https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=46b1f5963bc766e3ce036c5a17374fa94039db25 has more search failures, but anyway, you'll do them in a new bug.
|
|
||
Updated•4 years ago
|
Description
•