Closed Bug 1593188 Opened 5 years ago Closed 5 years ago

Follow movements of search engines in M-C

Categories

(Thunderbird :: Search, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 73.0

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

References

Details

Attachments

(3 files)

M-C are reworking their search engine implementation. Let's not open a bug for every little thing that needs to be tweaked.

I'll make a start with porting bug 1592014:
https://hg.mozilla.org/mozilla-central/rev/1e8a2884d6bfda4eddd63150583e189947369fed

Attached patch se-tweaks.patch (deleted) — Splinter Review

This should do it:
Basically copied engines.json from M-C again and repeated the steps from bug 1583383 comment #14 without removing the telemetry IDs:

  • removed eBay
  • removed extraParams (Yandex, DDG, Bing)
  • removed pc MOZI from Bing
  • removed tags and client with firefox
  • simplified Google appliesTo as suggested
  • removed "tn": "monline_7_dg" from Baidu since it wasn't in the WE
  • "tag": "mozillajapan-fx-22" and "tag": "mozilla-20" from Amazon, note sourceid=Mozilla-search is in the WEs

Checked JSON at https://jsonformatter.curiousconcept.com/

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=d88e7bc9222a02ff0bd757056bdd9ce6fb6fc673

Assignee: nobody → jorgk
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/94b8a3b37f15 Port bug 1592014: Change the WebExtension parameters of the modern configuration to be an object. rs=bustage-fix

sed -i -e '/engineName/d' engines.json.
Checked JSON at https://jsonformatter.curiousconcept.com/

Type: defect → task
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/8a5adb2c4820 Port bug 1592209: Remove engineName from the modern configuration. r=me
Attached patch 1593188-port-1595471.patch (deleted) — Splinter Review

Looks like bug 1600715 will need porting if tests blow up.

Flags: needinfo?(geoff)
Pushed by geoff@darktrojan.net: https://hg.mozilla.org/comm-central/rev/2ecec3c8f000 Port bug 1600715 changes to search engines; rs=bustage-fix DONTBUILD
Flags: needinfo?(geoff)
Assignee: jorgk-bmo → nobody

A bunch of tests from toolkit/components/search/tests have blown up again.
Last good: 5e69563343eb5bb7b8dfaaacc1e634e57d
First bad: 4f2f9bda72ac1c91576d2ca18d8323fe41
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5e69563343eb5bb7b8dfaaacc1e634e57d&tochange=4f2f9bda72ac1c91576d2ca18d8323fe41

Sadly there were three merges in this range, but anyway, easy to spot the issue: Bug 1590860, bug 1615309 and/or bug 1613348.

As a bustage fix you could likely get away with setting this pref:
https://hg.mozilla.org/mozilla-central/rev/7c6bdadeea29fab3700320515798d84ba3414f4f#l1.12

Any plans to address this?

Flags: needinfo?(mkmelin+mozilla)
Flags: needinfo?(geoff)

This has been dealt with in bug 1619173.

Flags: needinfo?(mkmelin+mozilla)
Flags: needinfo?(geoff)

If you say so. I'm surprised that none of bug 1590860, bug 1615309 and/or bug 1613348 needs further porting. And I put a bazillion incorrect stars onto the tree. I should stop doing so. Sorry.

Let's call this done then. Last landed patch in comment #8 in early Dec. 2019, so that makes it TB 73.

Status: NEW → RESOLVED
Closed: 5 years ago
Keywords: leave-open
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 73.0

Hmm, https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=46b1f5963bc766e3ce036c5a17374fa94039db25 has more search failures, but anyway, you'll do them in a new bug.

Assignee: nobody → jorgk-bmo
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: