If the region and/or locale is unknown, ensure the modern search config falls back to a reasonable default.
Categories
(Firefox :: Search, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox74 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(2 files)
I'm not sure if there's an explicit test for this, but we should make sure that if we've not got a region, we're falling back to a sensible default.
|
Assignee | |
Comment 1•5 years ago
|
||
It appears we already have handling for "default" for region - though we're not testing for it in the search config tests, so I'll add that.
The other bit that is missing is making sure that if we don't have a locale, then we fall back to a sensible set of engines. The good thing with the new configuration is that it is more region based so even if there's a locale we don't recognise, then we will have a minimal set that's reasonable. The minor downside is that it is not so explicit as to what is default in that case.
Hence I'll be adding a test for the locale case as well, and possibly some other fixes.
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 2•5 years ago
|
||
Also adds tests for checking the search engine lists when falling back to a default region.
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D59084
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/18b48dfaae65
https://hg.mozilla.org/mozilla-central/rev/a77944eb37ca
Description
•