Closed Bug 1542269 Opened 6 years ago Closed 5 years ago

Migrate the new Search Engine configuration to be loaded from RemoteSettings

Categories

(Firefox :: Search, task, P2)

Product:
Firefox
Component:
Search
Type:
task
Points:
5

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 76
Iteration:
76.1 - Mar 9 - Mar 22
Tracking Flags:
Tracking Status
firefox76 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 2 obsolete files)

Bug 1542269 - Make the modern search engine configuration be loaded from Remote Settings. r?daleharvey
(deleted), text/x-phabricator-request
Details

Once we've introduced the new configuration and integrated it (bug 1542268), we should allow it to be updated remotely so that we can replace the existing AB mechanism, and allow engine updates to happen more easily.

Iteration: --- → 69.3 - Jun 10 - 23
Priority: -- → P1

May have to land in 71- not nec preffable

Iteration: 69.3 - Jun 10 - 23 → 69.4 - Jun 24 - Jul 7
Iteration: 69.4 - Jun 24 - Jul 7 → 70.1 - Jul 8 - 21
Iteration: 70.1 - Jul 8 - 21 → ---
Blocks: 1575873
Assignee: nobody → standard8
Iteration: --- → 71.2 - Sept 16 - 29
No longer blocks: 1575873
Iteration: 71.2 - Sept 16 - 29 → 71.3 - Sept 30 - Oct 13
Priority: P1 → P2
Iteration: 71.3 - Sept 30 - Oct 13 → 71.4 - Oct 14 - 20
Iteration: 71.4 - Oct 14 - 20 → 72.1 - Oct 21 - Nov 3
Iteration: 72.1 - Oct 21 - Nov 3 → ---

In this bug we should also work out what happens if the configuration can't be found/loaded. Currently we fail initialisation, and as a result, we might stop parts of the browser working, e.g. address bar. It might be better to treat things the same as the legacy configuration - run with an empty set of engines, and don't fail initialisation. This should mean that at least some features can still work in the absolute worst case.

Status: NEW → ASSIGNED
Iteration: --- → 72.3 - Nov 18 - Dec 1
Depends on: 1600000

SearchService.reset() isn't designed to be called with reInit, but with init.

Depends on: 1600715

Comment on attachment 9112900 [details]
Bug 1542269 - In search tests, when running asyncReInit, don't reset the search service. r?mikedeboer

Revision D55462 was moved to bug 1601633. Setting attachment 9112900 [details] to obsolete.

Attachment #9112900 - Attachment is obsolete: true

Comment on attachment 9112901 [details]
Bug 1542269 - Switch some more search xpcshell-tests to use the useTestEngines helper function. r?mikedeboer

Revision D55463 was moved to bug 1601633. Setting attachment 9112901 [details] to obsolete.

Attachment #9112901 - Attachment is obsolete: true
Depends on: 1596860
Iteration: 72.3 - Nov 18 - Dec 1 → 74.2 - Jan 20 - Feb 09
Blocks: 1610847
Attachment #9112902 - Attachment description: Bug 1542269 - Make the modern search engine configuration be loaded from Remote Settings. r?mikedeboer → Bug 1542269 - Make the modern search engine configuration be loaded from Remote Settings. r?daleharvey
Blocks: 1612380
Blocks: 1612416
Blocks: 1613348
No longer blocks: 1613348
Iteration: 74.2 - Jan 20 - Feb 09 → 75.2 - Feb 24 - Mar 8
Iteration: 75.2 - Feb 24 - Mar 8 → 76.1 - Mar 9 - Mar 22
Blocks: 1622881
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bb19bd67310f Make the modern search engine configuration be loaded from Remote Settings. r=daleharvey

https://hg.mozilla.org/mozilla-central/rev/bb19bd67310f

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox76: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 76
Regressions: 1624301
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: