Closed Bug 1599662 Opened 5 years ago Closed 5 years ago

Do correct process selection in the reftest harness

Categories

(Testing :: Reftest, defect)

Product:
Testing
Component:
Reftest
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox73 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla73
Tracking Flags:
Tracking Status
firefox73 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(2 files)

Bug 1599662 - Add process switching to the reftest harness so that we can get better coverage for fission. r?dbaron,kmag
(deleted), text/x-phabricator-request
Details
Bug 1599662 - Invalidate the frame when we initialize rendering for a BrowserParent, since this might allocate a new layers id that would be cached on a display item. r?tnikkel
(deleted), text/x-phabricator-request
Details

The reftest harness is currently using <xul:browser> to load the test files which doesn't get to use any of the browser.js process selection.

This means it uses the default web process for most loads, not the file process, and doesn't really match what we ship.

Bug 1584031 also exposed an issue with 914521.html, which opens a new window (with a real browser.js) and we get different per-process behaviour.

Ideally we'd separate process switching from browser.js, so that this just works, but in the mean time we could use E10Utils to compute the remote type for the URL we want to load, and set the 'remoteType' attribue.

Assignee: nobody → matt.woodrow
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a7b980e65413 Add process switching to the reftest harness so that we can get better coverage for fission. r=kmag https://hg.mozilla.org/integration/autoland/rev/1a5918cfe128 Invalidate the frame when we initialize rendering for a BrowserParent, since this might allocate a new layers id that would be cached on a display item. r=tnikkel

Backed out 2 changesets (bug 1599662) for multiple reftest failures e.g. downscale-moz-icon-1.html on a CLOSED TREE.

Backout link: https://hg.mozilla.org/integration/autoland/rev/05b51ea086f337e6477d3e9837d9f7d96d1d2bba

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=1a5918cfe128992841682258cdc35c71c785bd01&selectedJob=279463261

Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279463261&repo=autoland&lineNumber=45802

Log snippet:

[task 2019-12-04T00:46:10.635Z] 00:46:10 INFO - REFTEST TEST-START | file:///Users/cltbld/tasks/task_1575419557/build/tests/reftest/tests/image/test/reftest/downscaling/downscale-moz-icon-1.html == file:///Users/cltbld/tasks/task_1575419557/build/tests/reftest/tests/image/test/reftest/downscaling/downscale-moz-icon-1-ref.html
[task 2019-12-04T00:46:10.635Z] 00:46:10 INFO - REFTEST INFO | RESTORE PREFERENCE pref(image.downscale-during-decode.enabled,false)
[task 2019-12-04T00:46:10.636Z] 00:46:10 INFO - REFTEST INFO | SET PREFERENCE pref(image.downscale-during-decode.enabled,true)
[task 2019-12-04T00:46:10.636Z] 00:46:10 INFO - REFTEST TEST-LOAD | file:///Users/cltbld/tasks/task_1575419557/build/tests/reftest/tests/image/test/reftest/downscaling/downscale-moz-icon-1.html | 109 / 136 (80%)
[task 2019-12-04T00:46:10.674Z] 00:46:10 INFO - [Child 1981, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 401
[task 2019-12-04T00:46:10.674Z] 00:46:10 INFO - [Child 1981, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 401
[task 2019-12-04T00:46:10.716Z] 00:46:10 INFO - REFTEST INFO | RESTORE PREFERENCE pref(image.downscale-during-decode.enabled,false)
[task 2019-12-04T00:46:10.717Z] 00:46:10 INFO - REFTEST INFO | SET PREFERENCE pref(image.downscale-during-decode.enabled,true)
[task 2019-12-04T00:46:10.717Z] 00:46:10 INFO - REFTEST TEST-LOAD | file:///Users/cltbld/tasks/task_1575419557/build/tests/reftest/tests/image/test/reftest/downscaling/downscale-moz-icon-1-ref.html | 109 / 136 (80%)
[task 2019-12-04T00:46:10.742Z] 00:46:10 INFO - [Child 1981, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 401
[task 2019-12-04T00:46:10.959Z] 00:46:10 INFO - REFTEST INFO | REFTEST fuzzy test (0, 0) <= (14, 6391) <= (53, 3604)
[task 2019-12-04T00:46:11.087Z] 00:46:11 INFO - REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/tasks/task_1575419557/build/tests/reftest/tests/image/test/reftest/downscaling/downscale-moz-icon-1.html == file:///Users/cltbld/tasks/task_1575419557/build/tests/reftest/tests/image/test/reftest/downscaling/downscale-moz-icon-1-ref.html | image comparison, max difference: 14, number of differing pixels: 6391
[

Flags: needinfo?(matt.woodrow)
Flags: needinfo?(matt.woodrow)
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b15c69feefa1 Add process switching to the reftest harness so that we can get better coverage for fission. r=kmag https://hg.mozilla.org/integration/autoland/rev/d46026afeb0e Invalidate the frame when we initialize rendering for a BrowserParent, since this might allocate a new layers id that would be cached on a display item. r=tnikkel

https://hg.mozilla.org/mozilla-central/rev/b15c69feefa1
https://hg.mozilla.org/mozilla-central/rev/d46026afeb0e

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla73
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: