Make the legacy config tests either run with both configurations, or make sure they turn the modern preference off
Categories
(Firefox :: Search, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox73 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(2 files)
We have six tests that are currently run for the legacy configuration only:
- test_maybereloadengine_update.js
- test_maybereloadengine_update_distro.js
- test_reloadEngines.js
- test_geodefaults.js
- test_hidden.js
- test_webextensions_install.js
Although some of these are to do with the geo/absearch configuration in the legacy config, we may still want some or all of these tests for the modern configuration.
We should take a look at these and fix them to work with the modern configuration if that is appropriate. Alternately we should change them to force the modern config preference to false so that when we turn the pref on, they don't fail.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #0)
We have six tests that are currently run for the legacy configuration only:
- test_maybereloadengine_update.js
- test_maybereloadengine_update_distro.js
- test_reloadEngines.js
- test_geodefaults.js
- test_hidden.js
- test_webextensions_install.js
Of these, I think test_webextensions_install.js is the main one we need to port. test_reloadEngines.js has some aspects, but we'll be adding new tests for those in bug 1542269 (rewriting the test here doesn't make sense).
The other tests are all specific to how ABSearch works, and we don't really need tests for those.
|
|
Assignee | |
Comment 2•5 years ago
|
||
|
|
Assignee | |
Comment 3•5 years ago
|
||
Depends on D55978
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/f5b3712e257e
https://hg.mozilla.org/mozilla-central/rev/dc630cb2d7ee
Description
•