[meta] Fix browser/components/sessionstore tests for Fission and SHIP
Categories
(Firefox :: Session Restore, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox89 | --- | fixed |
People
(Reporter: cpeterson, Assigned: u608768)
References
(Blocks 1 open bug)
Details
(Keywords: meta)
Attachments
(1 file)
(deleted),
text/x-phabricator-request
|
Details |
browser/components/sessionstore tests' Fission status as of 2019-12-09:
Test | Opt Status | Debug Status |
---|---|---|
browser/components/sessionstore/test/browser_586068-reload.js | passes | skipped |
browser/components/sessionstore/test/browser_615394-SSWindowState_events_undoCloseWindow.js | passes | skipped |
browser/components/sessionstore/test/browser_625016.js | skipped | skipped |
browser/components/sessionstore/test/browser_async_remove_tab.js | skipped | skipped |
browser/components/sessionstore/test/browser_async_window_flushing.js | skipped | skipped |
browser/components/sessionstore/test/browser_broadcast.js | skipped | skipped |
browser/components/sessionstore/test/browser_formdata.js | skipped | skipped |
browser/components/sessionstore/test/browser_sessionHistory.js | skipped | skipped |
browser/components/sessionstore/test/browser_sessionStorage.js | fails | fails |
browser/components/sessionstore/test/browser_upgrade_backup.js | fails | fails |
browser/components/sessionstore/test/browser_windowStateContainer.js | passes | skipped |
Reporter | ||
Updated•5 years ago
|
Comment 1•5 years ago
|
||
After investigation, the reason for failures of "browser/components/sessionstore/test/browser_sessionStorage.js" is Bug 1572084.
https://searchfox.org/mozilla-central/rev/c61720a7d0c094d772059f9d6a7844eb7619f107/toolkit/components/sessionstore/SessionStoreUtils.cpp#1172
In the failed case, the iframe is in a different process.
We will early return and don't collect sessionStore due to domWindow is null at that time.
Comment 2•5 years ago
|
||
browser_upgrade_backup.js is enabled in bug 1582531.
Comment 3•5 years ago
|
||
For browser_formdata.js,
JavaScript Error: "SecurityError: Permission denied to access property "document" on cross-origin object" {file: "chrome://mochitests/content/browser/browser/components/sessionstore/test/content-forms.js" line: 21}]
https://searchfox.org/mozilla-central/rev/c61720a7d0c094d772059f9d6a7844eb7619f107/browser/components/sessionstore/test/content-forms.js#21
Comment 4•5 years ago
|
||
For browser_async_remove_tab.js and browser_sessionHistory.js, these two are sessionHistory related.
Comment 5•5 years ago
|
||
browser_625016.js is not dependent on fission.
Reporter | ||
Comment 6•5 years ago
|
||
Tracking for Fission Nightly (M6) instead of M4.1 because some of these tests depend on SessionStoreListener Bug 1572084, which we are tracking for M6.
Reporter | ||
Comment 7•5 years ago
|
||
browser/components/sessionstore tests' Fission status as of 2020-04-26 looks a lot better:
Test Name | Test Status |
---|---|
browser_586068-reload.js | passes |
browser_615394-SSWindowState_events_undoCloseWindow.js | skip-if = ... non-Fission reasons |
browser_625016.js | skip-if = ... non-Fission reasons |
browser_async_remove_tab.js | skip-if = fission or debug |
browser_async_window_flushing.js | skip-if = fission |
browser_broadcast.js | passes |
browser_formdata.js | skip-if = fission or debug |
browser_sessionHistory.js | fail-if = fission |
browser_sessionStorage.js | fail-if = fission |
browser_upgrade_backup.js | skip-if = non-Fission reasons (including debug) |
browser_windowStateContainer.js | skip-if = fission or release linux |
Reporter | ||
Comment 8•4 years ago
|
||
Fixing session store tests is a Fission Nightly blocker (milestone M6c).
Comment 9•4 years ago
|
||
The current failing tests:
browser/components/sessionstore/test/browser_async_remove_tab.js
browser/components/sessionstore/test/browser_async_window_flushing.js
browser/components/sessionstore/test/browser_formdata.js
browser/components/sessionstore/test/browser_sessionHistory.js
browser/components/sessionstore/test/browser_sessionStorage.js
browser/components/sessionstore/test/browser_windowStateContainer.js
M-fis speadsheet: https://docs.google.com/spreadsheets/d/16G5AZhHWWow3rBgim4QBHzWXMIIJiky2SzXYgDMTTKY/
More info: https://wiki.mozilla.org/Project_Fission/Enabling_Tests_with_Fission#Cross-Origin_Mochitests
Updated•4 years ago
|
Updated•4 years ago
|
Comment 11•4 years ago
|
||
Currently Fission skipped tests:
browser/components/sessionstore/test/browser_formdata.js
browser/components/sessionstore/test/browser_sessionStorage.js
browser/components/sessionstore/test/browser_windowStateContainer.js
browser/components/sessionstore/test/browser_formdata_format.js
browser/components/sessionstore/test/browser_history_persist.js
Updated•4 years ago
|
Comment 12•4 years ago
|
||
In addition to the tests in comment 11, browser/components/sessionstore/test/browser_586068-reload.js
is skipped for SHIP
Assignee | ||
Comment 13•4 years ago
|
||
With patches for bug 1597499 from today and bug 1572084 from Mar. 2, browser_sessionStorage.js and browser_windowStateContainer.js are still failing. The first is failing because we aren't collecting session storage data for the inner origin, and the second is hanging when we're waiting for the window to close (we're not seeing the "SessionStore:update" message).
Assignee | ||
Comment 14•4 years ago
|
||
The bug 1572084 patches from Mar. 9 fix browser_windowStateContainer.js.
Assignee | ||
Comment 15•4 years ago
|
||
These are currently failing with both patches:
browser/components/sessionstore/test/browser_590563.js
browser/components/sessionstore/test/browser_615394-SSWindowState_events_setTabState.js
browser/components/sessionstore/test/browser_618151.js
browser/components/sessionstore/test/browser_636279.js
browser/components/sessionstore/test/browser_662743.js
browser/components/sessionstore/test/browser_662812.js
browser/components/sessionstore/test/browser_aboutSessionRestore.js
browser/components/sessionstore/test/browser_background_tab_crash.js
browser/components/sessionstore/test/browser_page_title.js
browser/components/sessionstore/test/browser_revive_crashed_bg_tabs.js
browser/components/sessionstore/test/browser_scrollPositions.js
browser/components/sessionstore/test/browser_scrollPositionsReaderMode.js
browser/components/sessionstore/test/browser_unrestored_crashedTabs.js
browser/components/sessionstore/test/browser_newtab_userTypedValue.js
browser/components/sessionstore/test/browser_restore_cookies_noOriginAttributes.js
All except the last fail locally as well. I haven't gone through to figure out what's causing them yet.
Assignee | ||
Comment 16•4 years ago
|
||
With the latest patches, these are failing consistently:
browser/components/sessionstore/test/browser_662743.js
browser/components/sessionstore/test/browser_scrollPositionsReaderMode.js
and these intermittently:
browser/components/sessionstore/test/browser_page_title.js (this might actually be a perma-fail)
browser/components/sessionstore/test/browser_scrollPositions.js
Assignee | ||
Comment 17•4 years ago
|
||
Currently failing:
- browser_scrollPositionsReaderMode.js
- browser_formdata.js
- browser_sessionStorage.js
- some leaks
The first will be fixed in bug 1698104 and the others will be fixed by the collection patches in bug 1572084.
Assignee | ||
Comment 18•4 years ago
|
||
Unskipped browser_586068-reload.js and browser_history_persist.js in bug 1597499. The others need both bugs.
The latest bug 1572084 patches have a fix for browser_formdata.js, but nothing for browser_sessionStorage.js yet. browser_scrollPositionsReaderMode.js will be unskipped in bug 1698104.
Updated•4 years ago
|
Assignee | ||
Comment 19•4 years ago
|
||
All tests should be fixed now. We still need to re-enable:
- browser_formdata.js
- browser_formdata_format.js
- browser_sessionStorage.js
- browser_windowStateContainer.js
Comment 20•4 years ago
|
||
Kashav, please unskip these and then close this meta bug.
Assignee | ||
Comment 21•4 years ago
|
||
These were fixed by bug 1572084 and bug 1597499.
Updated•4 years ago
|
Comment 22•4 years ago
|
||
Comment 23•4 years ago
|
||
bugherder |
Description
•