Closed Bug 1668084 Opened 4 years ago Closed 4 years ago

Fix browser_586068-reload.js for Fission+SHIP

Categories

(Core :: DOM: Navigation, defect, P2)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1597499
Fission Milestone M7

People

(Reporter: u608768, Assigned: u608768)

References

Details

Attachments

(2 obsolete files)

It hangs waiting for SSTabRestored events for restored tabs that are loaded via Location.reload(). This event is dispatched in response to STATE_STOP progress events seen by ContentRestore.jsm#ProgressListener. This listener lives in the content process, but since these loads may trigger a process switch, we may throwaway the listener prior to the completion of the load. A quick solution is add the listener to the browser element in the parent.

Type: task → defect
Attachment #9178565 - Attachment description: Bug 1668084 - Add a symmetrical parent-process ProgressListener for tab restores that may trigger process switches, r?peterv → Bug 1668084 - Add a symmetrical parent-process ProgressListener for tab restores with sessionHistoryInParent, r?peterv

Tests rely on seeing this event, but bug 1656997 made it so we never actually
call |SessionStore.restoreTab| for remoteness updates when the SHIP pref is
enabled. This reverts the changes from D86073 in favor of D86057.

Fission Milestone: M6b → M6c
Blocks: fission-history
No longer blocks: fission-history-m6b
Attachment #9179748 - Attachment is obsolete: true
Attachment #9178565 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE

Still fails with Kashav/Randell's patches in bug 1673617.

Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Assignee: kmadan → rjesup

Per discussion, this times out after reloading the first tab due to sessionstore using old-style process switch, and we also get a documentchannel process switch.

The solution here is to get rid of the old-style switch (messagemanager), and implement a way for a content process to ask the parent for state data for sub-frames.

Related to andreas' bug 1572084

May make sense to implement in C++

This will be done by Kashav in conjunction with the rewrite of session restore function in Bug 1597499.

Assignee: rjesup → kmadan
Status: REOPENED → ASSIGNED
Fission Milestone: M6c → M7
Blocks: 1602687

Will enable this in bug 1597499.

Status: ASSIGNED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: