UserScriptOptions js property shouldn't be optional
Categories
(WebExtensions :: General, defect, P5)
Tracking
(firefox75 fixed)
Tracking | Status | |
---|---|---|
firefox75 | --- | fixed |
People
(Reporter: rpl, Assigned: atiqueahmedziad, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug)
Attachments
(1 file, 1 obsolete file)
(deleted),
text/x-phabricator-request
|
Details |
The js
property is currently marked as optional in the API schema file, as it is in the RegisteredContentScriptOptions
related to the contentScripts API.
For the contentScripts the js
property is optional because an extension may register a CSS only contentScript, but it doesn't make much sense to register a userScript without any associated script and so it would make sense to make the js
property mandatory for userScripts.register
.
Reporter | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Hello Luca,
I want to work on it. I haven't worked on webExtension bugs earlier. Can you give me some instruction, how will I submit a patch for this bug ?
Thanks
Atique
Reporter | ||
Comment 2•5 years ago
|
||
(In reply to Atique Ahmed Ziad [:atiqueahmedziad] from comment #1)
Hello Luca,
I want to work on it. I haven't worked on webExtension bugs earlier. Can you give me some instruction, how will I submit a patch for this bug ?
Thanks
Atique
Hi Atique!
Some documentation on contributing to the WebExtensions API is available at https://wiki.mozilla.org/WebExtensions/Contribution_Onramp
Once your development environment setup is done, comment 0 includes a link to the part of the user_scripts.json API schema file relevant to this issue.
It would be good to also add a test case that covers the fix to the API JSON schema, by adding a new test case to the userScripts tests that verify that the js
property is not optional and browser.userScripts.register
fails as expected when called without it.
The main group of test cases related to the userScripts API is in the toolkit/components/extensions/test/xpcshell/test_ext_userScripts.js test file.
Assignee | ||
Comment 3•5 years ago
|
||
Updated•5 years ago
|
Assignee | ||
Comment 4•5 years ago
|
||
Depends on D60996
Updated•5 years ago
|
Reporter | ||
Comment 5•5 years ago
|
||
Comment on attachment 9122941 [details]
Bug 1605403 - UserScriptOptions js property shouldn't be optional. r=rpl
Marking as obsolete (this patch is being abandoned in favor of D61002, which now includes the content originally split in the two phabricator revisions).
Updated•5 years ago
|
Pushed by apavel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/80ae1b003c69 UserScriptOptions js property shouldn't be optional. r=rpl
Comment 7•5 years ago
|
||
bugherder |
Updated•4 years ago
|
Description
•