Closed Bug 1608449 Opened 5 years ago Closed 5 years ago

Disable LSNG in 73

Categories

(Core :: Storage: localStorage & sessionStorage, task, P1)

task

Tracking

()

VERIFIED FIXED
mozilla74
Tracking Status
firefox73 blocking verified
firefox74 --- verified

People

(Reporter: janv, Assigned: janv)

References

Details

Attachments

(2 files)

We can't ship it on Release until storage initialization failures are addressed.

There seems to be one failing test currently:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c47f30849bb0db8950360149b311756f2b918fb7

Assignee: nobody → jvarga
Severity: normal → critical

Jan, would it be possible to have a beta patch to disable LSNG before the allhands? Thanks

Flags: needinfo?(jvarga)

Yeah, working on it. There's one test that is failing with LSNG disabled.

Priority: P2 → P1
Status: NEW → ASSIGNED
Flags: needinfo?(jvarga)

Comment on attachment 9122736 [details]
Bug 1608449 - Disable LSNG in 73; r=asuth

Beta/Release Uplift Approval Request

  • User impact if declined: If LSNG is enabled, LocalStorage depends on QuotaManager storage which is currently broken for some users. We don't want to ship LSNG until the issue is fixed.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): This patch just disables LSNG, so the old implementation of LocalStorage will be used in FF 72. We fully support downgrading of LocalStorage data, so if some users already tried a beta build, they should be safe. We disabled LSNG in previous beta cycles and there were no problems reported after the switch.
  • String changes made/needed: None
Attachment #9122736 - Flags: approval-mozilla-beta?
Attachment #9122737 - Flags: approval-mozilla-beta?

Comment on attachment 9122737 [details]
Bug 1608449 - Test fixes for old localStorage implementation; r=asuth

IIUC, D60883 includes these changes already. This is just needed for trunk.

Attachment #9122737 - Flags: approval-mozilla-beta?

Comment on attachment 9122736 [details]
Bug 1608449 - Disable LSNG in 73; r=asuth

Approved for 73.0b9.

Attachment #9122736 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Regressions: 1611317
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f73bfe55131b Test fixes for old localStorage implementation; r=asuth
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla74

We should have QA verify this.

Flags: qe-verify+
QA Whiteboard: [qa-triaged]

Patch verified with:

  • Windows 10 with 73.0, 74.0a1(2020-02-02;
  • Ubuntu 19.04 with 73.0b11, 74.0a1(2020-02-04);
  • macOS 10.13.6 with 73.0b12, 74.0a1(2020-02-03);
Status: RESOLVED → VERIFIED
Flags: qe-verify+

Hello, I verified that this issue is fixed using the latest version of Firefox Preview Nightly 2/4 #20350605 and Firefox Preview Beta 3.2.0-beta.3.

Devices:

  • Samsung Galaxy Note 8 (Android 9);
  • Motorola Moto G6 (Android 8).
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: