Disable LSNG in 73
Categories
(Core :: Storage: localStorage & sessionStorage, task, P1)
Tracking
()
People
(Reporter: janv, Assigned: janv)
References
Details
Attachments
(2 files)
(deleted),
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details |
(deleted),
text/x-phabricator-request
|
Details |
We can't ship it on Release until storage initialization failures are addressed.
There seems to be one failing test currently:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c47f30849bb0db8950360149b311756f2b918fb7
Updated•5 years ago
|
Comment 1•5 years ago
|
||
Jan, would it be possible to have a beta patch to disable LSNG before the allhands? Thanks
Assignee | ||
Comment 2•5 years ago
|
||
Yeah, working on it. There's one test that is failing with LSNG disabled.
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
Testing mozilla-central:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=52eb0cec7ba8e7306b2ce7f04e389a483b011170
Testing mozilla-beta:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=90a97ed47afc84336b085916293dde7953c1503f
Assignee | ||
Comment 4•5 years ago
|
||
Assignee | ||
Comment 5•5 years ago
|
||
Comment 6•5 years ago
|
||
Comment on attachment 9122736 [details]
Bug 1608449 - Disable LSNG in 73; r=asuth
Beta/Release Uplift Approval Request
- User impact if declined: If LSNG is enabled, LocalStorage depends on QuotaManager storage which is currently broken for some users. We don't want to ship LSNG until the issue is fixed.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This patch just disables LSNG, so the old implementation of LocalStorage will be used in FF 72. We fully support downgrading of LocalStorage data, so if some users already tried a beta build, they should be safe. We disabled LSNG in previous beta cycles and there were no problems reported after the switch.
- String changes made/needed: None
Updated•5 years ago
|
Comment 7•5 years ago
|
||
Comment on attachment 9122737 [details]
Bug 1608449 - Test fixes for old localStorage implementation; r=asuth
IIUC, D60883 includes these changes already. This is just needed for trunk.
Comment 8•5 years ago
|
||
Comment on attachment 9122736 [details]
Bug 1608449 - Disable LSNG in 73; r=asuth
Approved for 73.0b9.
Comment 9•5 years ago
|
||
uplift |
Comment 10•5 years ago
|
||
Comment 11•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Comment 13•5 years ago
|
||
Patch verified with:
- Windows 10 with 73.0, 74.0a1(2020-02-02;
- Ubuntu 19.04 with 73.0b11, 74.0a1(2020-02-04);
- macOS 10.13.6 with 73.0b12, 74.0a1(2020-02-03);
Comment 14•5 years ago
|
||
Hello, I verified that this issue is fixed using the latest version of Firefox Preview Nightly 2/4 #20350605 and Firefox Preview Beta 3.2.0-beta.3.
Devices:
- Samsung Galaxy Note 8 (Android 9);
- Motorola Moto G6 (Android 8).
Updated•5 years ago
|
Description
•