[Affected versions]:

• Firefox Release 72.0.1 - Build ID: 20200107212822
• Firefox Beta 73.0b4 - Build ID: 20200112220634
• Firefox Nightly 74.0a1 - Build ID: 20200114094410

[Affected Platforms]:

• Windows 10 x64
• Mac 10.15.2
• Ubuntu 18.04 x64

[Prerequisites]:

• Have a Firefox profile with the "browser.search.region" pref set to "US" in the "about:config" page.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Navigate to the "about:preferences#home" page.
3. Uncheck the "Top Sites" and "Recommended by Pocket" options.
4. Open a new tab and observe the displayed elements.

[Expected result]:

• Only the in-content "Search Bar" and the "Highlights" section are displayed.

[Actual result]:

• The "Firefox" name and logo are also displayed above the in-content "Search Bar".

[Regression Window]:

• Considering the fact that this issue is not reproducible on older Firefox versions, using the Mozregression tool, we have managed to find the following pushlog:
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8e8ea33ecb3da138dbd0af56c2e5550902e7b05a&tochange=777492b75f9745bd78dc96155ccd91523b788db0

From the pushlog, it seems that bug 1552289 has caused this behavior.

[Notes]:

• This issue is also reproducible with the "Discovery Steam" experience for the rest of the world.
• This issue is not reproducible on the "control" branch of the experiment.

Aaron, could you please give us your opinion regarding this?

Yeah this is unexpected as the logo should appear only when the search field is the only visible section.

I think I see what happened.

Initially, when we did the search only work, highlights wasn't enabled yet in Discovery Stream.

"This is because the search-only view is expecting highlights to be off, but that section doesn't exist in the settings for discovery stream"

So since then, we've integrated highlights, but looks like we forgot to round this part out.

The actual regression bug is probably when we enabled highlights in DS. I'll see if I can find it, but also I'll fix this asap.

My guess is this is the regression https://bugzilla.mozilla.org/show_bug.cgi?id=1536285

https://hg.mozilla.org/mozilla-central/rev/5d9ae5b93fca

Please nominate this for Beta approval if you think it's worth taking.

[Tracking Requested - why for this release]: Worth taking because of how small the change is and how low risk it is. It has a noticeable UI improvement for some users.

Hi Scott, tracking+ doesn't guarantee uplift. The patch still needs a regular Beta approval request.

Ah interesting.

So I knew tracking+ wasn't all that was needed, but I also thought I needed to wait until tracking went from ? to + before taking it to the next step.

So to be clear, it is acceptable for me to create the attachment while still in ? without the + on the approval? (I don't know where I heard that tbh, so it's probably an incorrect assumption on my end)

Comment on attachment 9120826 [details]
Bug 1609160 - Search only logo displayed with just highlights.

Beta/Release Uplift Approval Request

• User impact if declined: It has a noticeable UI improvement for some users.

• Is this code covered by automated tests?: Yes

• Has the fix been verified in Nightly?: No

• Needs manual test from QE?: Yes

• If yes, steps to reproduce: [Steps to reproduce]:

  Open the browser with the profile from prerequisites.
  Navigate to the "about:preferences#home" page.
  Uncheck the "Top Sites" and "Recommended by Pocket" options.
  Open a new tab and observe the displayed elements.

[Expected result]:

Only the in-content "Search Bar" and the "Highlights" section are displayed.

[Actual result]:

The "Firefox" name and logo are also displayed above the in-content "Search Bar".

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Worth taking because of how small the change.
• String changes made/needed:

(In reply to Scott [:thecount] Downe from comment #11)

So to be clear, it is acceptable for me to create the attachment while still in ? without the + on the approval? (I don't know where I heard that tbh, so it's probably an incorrect assumption on my end)

Tracking+ basically just means "this is a bug we want to keep on our radar." It's not strictly tied to uplifting in the end since that decision ultimately rests on the relative risks associated with the patch in question. We're certainly more likely to want to uplift patches with tracking status, but it's not a necessary requirement for uplift either.

Comment on attachment 9120826 [details]
Bug 1609160 - Search only logo displayed with just highlights.

Low-risk fix for a minor visual issue on the New Tab Page. Approved for 73.0b7.

Conflicts when we tried to uplift this bug:

• conflicts while merging browser/components/newtab/content-src/components/Base/Base.jsx
• conflicts while merging browser/components/newtab/data/content/activity-stream.bundle.js

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (74.0a1 Build ID - 20200119213718) installed, on Windows 10 x64, Ubuntu 18.04 x64 and Mac 10.15.2. Now the "Firefox" name and logo are no longer displayed if the "Highlights" section is enabled.

Comment on attachment 9122163 [details]
Bug 1609160 - Search only logo displayed with just highlights.

Beta/Release Uplift Approval Request

• User impact if declined: It has a noticeable UI improvement for some users.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Open the browser with the profile from prerequisites.
  Navigate to the "about:preferences#home" page.
  Uncheck the "Top Sites" and "Recommended by Pocket" options.
  Open a new tab and observe the displayed elements.

[Expected result]:

Only the in-content "Search Bar" and the "Highlights" section are displayed.

[Actual result]:

The "Firefox" name and logo are also displayed above the in-content "Search Bar".

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Worth taking because of how small the change.
• String changes made/needed:

Made a new phabricator pr against an updated beta, should do the trick.

I didn't see how to close my other one.

Comment on attachment 9122163 [details]
Bug 1609160 - Search only logo displayed with just highlights.

Thanks for rebasing. Approved for 73.0b8.

https://hg.mozilla.org/releases/mozilla-beta/rev/ebc9e4233250

I have verified that this issue is no longer reproducible with the latest Firefox Beta (73.0b8 Build ID - 20200122012721) installed, on Windows 10 x64, Ubuntu 18.04 x64 and Mac 10.15.2. Now the "Firefox" name and logo are no longer displayed if the "Highlights" section is enabled.