[web-animations-1] Dependency on CSSPseudoElement
Categories
(Core :: DOM: Animation, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox75 | --- | fixed |
People
(Reporter: mozilla-apprentice, Assigned: boris)
References
(Blocks 2 open bugs)
Details
Attachments
(3 files)
A resolution was made for csswg-drafts/#4301.
[web-animations-1] Dependency on CSSPseudoElement
- RESOLVED: Pseudo elements are targeted via a parent plus a pseudo selector
|
Assignee | |
Comment 1•4 years ago
|
||
Perhaps we should wait for this PR merged: https://github.com/w3c/csswg-drafts/pull/4616 before working on this.
|
||
Comment 2•4 years ago
|
||
I've chased up the issue but I'm not sure we need to wait for it to be merged. I think there's enough of an outline there that we can start working on this. Doing that will help us to give more useful feedback too. (And I'm afraid if we don't start on it soon, we will be the last to ship getAnimations.)
|
|
Assignee | |
Comment 3•4 years ago
|
||
I'm ok to work on this in the meantime (and keep tracking your review feedback on the PR). :)
|
|
Assignee | |
Updated•4 years ago
|
|
|
Assignee | |
Comment 4•4 years ago
|
||
In order to store the different combinations of (Element, PsuedoStyleType)
pairs, including (nullptr, ::before/::after), we drop Maybe<> and use
OwningAnimationTarget directly.
|
|
Assignee | |
Comment 5•4 years ago
|
||
Replace ElementOrCSSPseudoElement with Element and add PseudoElement (which is
a DOMString) into KeyframeAnimationOptions and KeyframeEffect.
|
|
Assignee | |
Comment 6•4 years ago
|
||
Pushed by bchiou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0544d8d97106 Drop Maybe<> from KeyframeEffect::mTarget. r=birtles https://hg.mozilla.org/integration/autoland/rev/ebfed5eb1869 Eliminate usage of CSSPseudoElement from KeyframeEffect. r=birtles,smaug https://hg.mozilla.org/integration/autoland/rev/df47b5f850b6 Add a separate pref for CSSPseudoElement. r=smaug
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/21870 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
|
||
Comment 10•4 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0544d8d97106
https://hg.mozilla.org/mozilla-central/rev/ebfed5eb1869
https://hg.mozilla.org/mozilla-central/rev/df47b5f850b6
Upstream PR merged by moz-wptsync-bot
Description
•